🐛 :: Completable.asObservable().flatMap dead-code 버그 수정

leejh08 · claude · leejh08 · commit 813a8d77c027 · 2026-06-25T14:06:57.000+09:00
Completable.asObservable()은 Observable&lt;Never&gt;가 되어 .next 이벤트가
절대 발생하지 않으므로, 이를 .flatMap/.map으로 받아 Mutation을
만들던 코드는 컴파일러가 보장하는 dead code였음. RxSwift 표준 패턴인
Completable.andThen(Observable&lt;Element&gt;)으로 교체.

- 실제 동작 버그 수정: AlarmReactor(읽음 처리), MyPageReactor(프로필
  이미지 변경), BugReportReactor(제출 완료), NotificationSettingReactor
  (알림 토글) — API 성공 후 의도한 Mutation이 발생하도록 수정
- 무해하지만 오해를 부르던 dead code 정리: InterestFieldReactor,
  OnboardingReactor, RecruitmentReactor, RecruitmentDetailReactor,
  SearchRecruitmentReactor, WinterInternReactor, WinterInternDetailReactor

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/Projects/Presentation/Sources/BugReport/BugReportReactor.swift b/Projects/Presentation/Sources/BugReport/BugReportReactor.swift
@@ -79,8 +79,7 @@ extension BugReportReactor {
                 developmentArea: DevelopmentType(localizedString: currentState.majorType) ?? .all,
                 attachmentUrls: currentState.imageList
             ))
-            .asObservable()
-            .map { _ in Mutation.setBugReportCompleted }
+            .andThen(.just(.setBugReportCompleted))
         }
     }
 
diff --git a/Projects/Presentation/Sources/Home/Alarm/AlarmReactor.swift b/Projects/Presentation/Sources/Home/Alarm/AlarmReactor.swift
@@ -57,10 +57,7 @@ extension AlarmReactor {
                 new: false
             )
             return readNotificationUseCase.execute(id: notification.notificationID)
-                .asObservable()
-                .flatMap { _ -> Observable<Mutation> in
-                    .just(.updateNotification(index: index, notification: updatedNotification))
-                }
+                .andThen(.just(.updateNotification(index: index, notification: updatedNotification)))
         }
     }
 
diff --git a/Projects/Presentation/Sources/InterestField/InterestFieldReactor.swift b/Projects/Presentation/Sources/InterestField/InterestFieldReactor.swift
@@ -70,11 +70,10 @@ extension InterestFieldReactor {
         case .selectButtonDidTap:
             let codeIDs = currentState.selectedInterests.map { $0.code }
             return changeInterestsUseCase.execute(codeIDs: codeIDs)
-                .asObservable()
                 .do(onCompleted: { [weak self] in
                     self?.steps.accept(InterestFieldStep.interestFieldCheckIsRequired)
                 })
-                .flatMap { _ in Observable<Mutation>.empty() }
+                .andThen(.empty())
         }
     }
 
diff --git a/Projects/Presentation/Sources/MyPage/MyPageReactor.swift b/Projects/Presentation/Sources/MyPage/MyPageReactor.swift
@@ -88,23 +88,19 @@ public final class MyPageReactor: BaseReactor, Stepper {
                 guard let self = self,
                       let url = presignedURLs.first else { return .empty() }
 
-                return Observable.zip(
+                return Completable.zip(
                     self.uploadImageToS3UseCase.execute(
                         presignedURL: url.presignedUrl,
                         data: file.file
-                    )
-                    .asObservable(),
+                    ),
                     self.changeProfileImageUseCase.execute(url: url.filePath)
-                        .asObservable()
                 )
-                .flatMap { _ in
-                    Observable.concat([
-                        .just(.updateProfileImage),
-                        self.fetchStudentInfoUseCase.execute()
-                            .asObservable()
-                            .map { Mutation.setStudentInfo($0) }
-                    ])
-                }
+                .andThen(Observable.concat([
+                    .just(.updateProfileImage),
+                    self.fetchStudentInfoUseCase.execute()
+                        .asObservable()
+                        .map { Mutation.setStudentInfo($0) }
+                ]))
             }
 
         case .notificationSettingDidTap:
diff --git a/Projects/Presentation/Sources/NotificationSetting/NotificationSettingReactor.swift b/Projects/Presentation/Sources/NotificationSetting/NotificationSettingReactor.swift
@@ -75,14 +75,12 @@ extension NotificationSettingReactor {
                 token: Messaging.messaging().fcmToken ?? "",
                 notificationType: notificationType
             )
-            .asObservable()
-            .map { _ in .toggleNotificationState(notificationType) }
+            .andThen(.just(.toggleNotificationState(notificationType)))
 
         case .toggleAllNotifications:
             let newState = !currentState.isAllNotificationEnabled
             return subscribeAllNotificationUseCase.execute()
-                .asObservable()
-                .map { _ in .setAllNotificationStates(newState) }
+                .andThen(.just(.setAllNotificationStates(newState)))
         }
     }
 
diff --git a/Projects/Presentation/Sources/Onboarding/OnboardingReactor.swift b/Projects/Presentation/Sources/Onboarding/OnboardingReactor.swift
@@ -86,8 +86,7 @@ public final class OnboardingReactor: BaseReactor {
             .catch { _ in .just(.setShowNavigationButton) }
 
         let serverStatusCheck = fetchServerStatusUseCase.execute()
-            .asObservable()
-            .flatMap { _ in Observable<Mutation>.empty() }
+            .andThen(Observable<Mutation>.empty())
             .catch { _ in .just(.setServerStatusError) }
 
         return .merge(tokenCheck, serverStatusCheck)
diff --git a/Projects/Presentation/Sources/Recruitment/RecruitmentReactor.swift b/Projects/Presentation/Sources/Recruitment/RecruitmentReactor.swift
@@ -101,9 +101,7 @@ extension RecruitmentReactor {
         case let .bookmarkButtonDidTap(id):
             return .concat([
                 .just(.updateBookmark(id)),
-                bookmarkUseCase.execute(id: id)
-                    .asObservable()
-                    .flatMap { _ in Observable<Mutation>.empty() }
+                bookmarkUseCase.execute(id: id).andThen(.empty())
             ])
 
         case let .recruitmentDidSelect(id):
diff --git a/Projects/Presentation/Sources/RecruitmentDetail/RecruitmentDetailReactor.swift b/Projects/Presentation/Sources/RecruitmentDetail/RecruitmentDetailReactor.swift
@@ -70,9 +70,8 @@ extension RecruitmentDetailReactor {
                 return .empty()
             }
             return bookmarkUseCase.execute(id: recruitmentID)
-                .asObservable()
                 .catch { _ in .empty() }
-                .flatMap { _ in Observable<Mutation>.empty() }
+                .andThen(.empty())
 
         case .applyButtonDidTap:
             guard let detail = currentState.recruitmentDetail else {
diff --git a/Projects/Presentation/Sources/SearchRecruitment/SearchRecruitmentReactor.swift b/Projects/Presentation/Sources/SearchRecruitment/SearchRecruitmentReactor.swift
@@ -71,9 +71,7 @@ extension SearchRecruitmentReactor {
             ])
 
         case let .bookmarkButtonDidTap(id):
-            return bookmarkUseCase.execute(id: id)
-                .asObservable()
-                .flatMap { _ in Observable<Mutation>.empty() }
+            return bookmarkUseCase.execute(id: id).andThen(.empty())
 
         case let .recruitmentDidSelect(id):
             steps.accept(SearchRecruitmentStep.recruitmentDetailIsRequired(id: id))
diff --git a/Projects/Presentation/Sources/WinterIntern/WinterInternReactor.swift b/Projects/Presentation/Sources/WinterIntern/WinterInternReactor.swift
@@ -90,9 +90,7 @@ extension WinterInternReactor {
         case let .bookmarkButtonDidTap(id):
             return .concat([
                 .just(.updateBookmark(id)),
-                bookmarkUseCase.execute(id: id)
-                    .asObservable()
-                    .flatMap { _ in Observable<Mutation>.empty() }
+                bookmarkUseCase.execute(id: id).andThen(.empty())
             ])
 
         case let .recruitmentDidSelect(id):
diff --git a/Projects/Presentation/Sources/WinterInternDetail/WinterInternDetailReactor.swift b/Projects/Presentation/Sources/WinterInternDetail/WinterInternDetailReactor.swift
@@ -69,9 +69,8 @@ extension WinterInternDetailReactor {
                 return .empty()
             }
             return bookmarkUseCase.execute(id: recruitmentID)
-                .asObservable()
                 .catch { _ in .empty() }
-                .flatMap { _ in Observable<Mutation>.empty() }
+                .andThen(.empty())
 
         case .applyButtonDidTap:
             guard let detail = currentState.recruitmentDetail else {

Original file line number	Diff line number	Diff line change
`@@ -79,8 +79,7 @@ extension BugReportReactor {`
`79`	`79`	`developmentArea: DevelopmentType(localizedString: currentState.majorType) ?? .all,`
`80`	`80`	`attachmentUrls: currentState.imageList`
`81`	`81`	`))`
`82`		`- .asObservable()`
`83`		`- .map { _ in Mutation.setBugReportCompleted }`
	`82`	`+ .andThen(.just(.setBugReportCompleted))`
`84`	`83`	`}`
`85`	`84`	`}`
`86`	`85`
Original file line number	Diff line number	Diff line change
`@@ -57,10 +57,7 @@ extension AlarmReactor {`
`57`	`57`	`new: false`
`58`	`58`	`)`
`59`	`59`	`return readNotificationUseCase.execute(id: notification.notificationID)`
`60`		`- .asObservable()`
`61`		`- .flatMap { _ -> Observable<Mutation> in`
`62`		`- .just(.updateNotification(index: index, notification: updatedNotification))`
`63`		`- }`
	`60`	`+ .andThen(.just(.updateNotification(index: index, notification: updatedNotification)))`
`64`	`61`	`}`
`65`	`62`	`}`
`66`	`63`
Original file line number	Diff line number	Diff line change
`@@ -70,11 +70,10 @@ extension InterestFieldReactor {`
`70`	`70`	`case .selectButtonDidTap:`
`71`	`71`	`let codeIDs = currentState.selectedInterests.map { $0.code }`
`72`	`72`	`return changeInterestsUseCase.execute(codeIDs: codeIDs)`
`73`		`- .asObservable()`
`74`	`73`	`.do(onCompleted: { [weak self] in`
`75`	`74`	`self?.steps.accept(InterestFieldStep.interestFieldCheckIsRequired)`
`76`	`75`	`})`
`77`		`- .flatMap { _ in Observable<Mutation>.empty() }`
	`76`	`+ .andThen(.empty())`
`78`	`77`	`}`
`79`	`78`	`}`
`80`	`79`
Original file line number	Diff line number	Diff line change
`@@ -75,14 +75,12 @@ extension NotificationSettingReactor {`
`75`	`75`	`token: Messaging.messaging().fcmToken ?? "",`
`76`	`76`	`notificationType: notificationType`
`77`	`77`	`)`
`78`		`- .asObservable()`
`79`		`- .map { _ in .toggleNotificationState(notificationType) }`
	`78`	`+ .andThen(.just(.toggleNotificationState(notificationType)))`
`80`	`79`
`81`	`80`	`case .toggleAllNotifications:`
`82`	`81`	`let newState = !currentState.isAllNotificationEnabled`
`83`	`82`	`return subscribeAllNotificationUseCase.execute()`
`84`		`- .asObservable()`
`85`		`- .map { _ in .setAllNotificationStates(newState) }`
	`83`	`+ .andThen(.just(.setAllNotificationStates(newState)))`
`86`	`84`	`}`
`87`	`85`	`}`
`88`	`86`