Skip to content

๐Ÿ”— :: (#0) TDD/Tidy First ์ž‘์—… ๊ทœ์น™ ์ถ”๊ฐ€ ๋ฐ CompanyDetailPreviousViewType ์ •๋ฆฌ#438

Open
leejh08 wants to merge 5 commits into
developfrom
chore/tdd-tidy-first-plan
Open

๐Ÿ”— :: (#0) TDD/Tidy First ์ž‘์—… ๊ทœ์น™ ์ถ”๊ฐ€ ๋ฐ CompanyDetailPreviousViewType ์ •๋ฆฌ#438
leejh08 wants to merge 5 commits into
developfrom
chore/tdd-tidy-first-plan

Conversation

@leejh08
Copy link
Copy Markdown
Member

@leejh08 leejh08 commented Apr 28, 2026

Summary

  • ๋ฃจํŠธ plan.md๋ฅผ ์ถ”๊ฐ€ํ•ด TDD / Tidy First / go ์‹คํ–‰ ๊ทœ์น™์„ ๋ฌธ์„œํ™”
  • CompanyDetailPreviousViewType๋ฅผ Core ๋‹จ์ผ ์ •์˜๋กœ ์ •๋ฆฌํ•˜๊ณ  Presentation ์ค‘๋ณต ์ •์˜ ์ œ๊ฑฐ

Test plan

  • tuist test Presentation
  • swiftlint lint Projects/Core/Sources/Steps/CompanyDetailPreviousViewType.swift
  • tuist test Core (GoogleDataTransport ๋นŒ๋“œ ์ค‘ nanopb/pb.h ๋ˆ„๋ฝ์œผ๋กœ ์‹คํŒจ)

๋ฃจํŠธ plan.md๋ฅผ ์ถ”๊ฐ€ํ•ด ์•ž์œผ๋กœ์˜ Red-Green-Refactor / Tidy First ์ž‘์—… ๊ทœ์น™์„ ๋ช…์‹œํ•˜๊ณ ,
์ค‘๋ณต๋˜์–ด ์žˆ๋˜ CompanyDetailPreviousViewType ์ •์˜๋ฅผ Core ๋‹จ์ผ ์†Œ์Šค๋กœ ์ •๋ฆฌํ–ˆ๋‹ค.
์ด๋ฒˆ ๋ณ€๊ฒฝ์€ ๋™์ž‘ ์ถ”๊ฐ€ ์—†์ด ๊ตฌ์กฐ์™€ ์ž‘์—… ๊ทœ์น™๋งŒ ๊ณ ์ •ํ•˜๋Š” ๋ชฉ์ ์ด๋‹ค.

Constraint: ์‚ฌ์šฉ์ž ์š”์ฒญ์— ๋”ฐ๋ผ ์•ž์œผ๋กœ์˜ go ์‹คํ–‰์€ plan.md๋ฅผ ๊ธฐ์ค€์œผ๋กœ ์ง„ํ–‰๋˜์–ด์•ผ ํ•œ๋‹ค
Constraint: ๊ตฌ์กฐ ๋ณ€๊ฒฝ๊ณผ ๋™์ž‘ ๋ณ€๊ฒฝ์„ ๊ฐ™์€ ์ปค๋ฐ‹์— ์„ž์ง€ ์•Š๋Š”๋‹ค
Rejected: ๊ธฐ๋Šฅ ํ…Œ์ŠคํŠธ/๊ตฌํ˜„๊นŒ์ง€ ์ด๋ฒˆ ์ปค๋ฐ‹์— ํฌํ•จ | TDD ์‹œ์ž‘์ ๊ณผ ๊ตฌ์กฐ ์ •๋ฆฌ๋ฅผ ๋ถ„๋ฆฌํ•ด์•ผ ํ•จ
Confidence: medium
Scope-risk: narrow
Reversibility: clean
Directive: ๋‹ค์Œ ๊ธฐ๋Šฅ ์ž‘์—…๋ถ€ํ„ฐ๋Š” plan.md์˜ Test Queue์— failing test๋ฅผ ๋จผ์ € ์ ๊ณ  ํ•œ ํ•ญ๋ชฉ์”ฉ๋งŒ ์ง„ํ–‰ํ•  ๊ฒƒ
Tested: tuist test Presentation
Tested: swiftlint lint Projects/Core/Sources/Steps/CompanyDetailPreviousViewType.swift
Not-tested: tuist test Core | GoogleDataTransport ๋นŒ๋“œ์—์„œ 'nanopb/pb.h' ๋ˆ„๋ฝ์œผ๋กœ ์‹คํŒจ
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7c862a81-112e-46d1-b8e3-be1001f41e10

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ๐Ÿ” Trigger review
โœจ Finishing Touches
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/tdd-tidy-first-plan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

leejh08 added 4 commits April 28, 2026 14:36
plan.md๋Š” ์ €์žฅ์†Œ ์ „์—ญ TDD/Tidy First ๊ทœ์น™ ๋ฌธ์„œ๋กœ ์œ ์ง€ํ•˜๊ณ ,
์ผํšŒ์„ฑ ๊ตฌ์กฐ ๋ณ€๊ฒฝ ๊ธฐ๋ก์€ ์ œ๊ฑฐํ–ˆ๋‹ค.

Constraint: plan.md๋Š” ํŠน์ • ์ž‘์—… ๋กœ๊ทธ๊ฐ€ ์•„๋‹ˆ๋ผ ์•ž์œผ๋กœ์˜ ๊ณตํ†ต ์‹คํ–‰ ๊ธฐ์ค€์ด์–ด์•ผ ํ•œ๋‹ค
Rejected: ์™„๋ฃŒ๋œ ๊ตฌ์กฐ ๋ณ€๊ฒฝ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ์œ ์ง€ | ๋ฌธ์„œ๊ฐ€ ์ž‘์—…๋ณ„ ์ƒํƒœํŒ์œผ๋กœ ๋ณ€์งˆ๋จ
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: plan.md์—๋Š” ์ „์—ญ ๊ทœ์น™๊ณผ ๋‹ค์Œ ํ…Œ์ŠคํŠธ ํ๋งŒ ์œ ์ง€ํ•˜๊ณ  ์ž‘์—… ์™„๋ฃŒ ์ด๋ ฅ์€ ๋‚จ๊ธฐ์ง€ ๋ง ๊ฒƒ
Tested: plan.md diff review
Not-tested: additional automated checks not applicable to markdown-only edit
Kent Beck์˜ TDD/ Tidy First๋ฅผ ์ด ์ €์žฅ์†Œ์—์„œ ์‹ค์ œ๋กœ ์ ์šฉํ•  ์ˆ˜ ์žˆ๋„๋ก
plan.md์˜ ์‹คํ–‰ ๊ณ„์•ฝ์„ ๊ตฌ์ฒดํ™”ํ•˜๊ณ  PR ํ…œํ”Œ๋ฆฟ์— ๊ฒ€์ฆ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ–ˆ๋‹ค.
์ด์ œ go ๋ช…๋ น์€ ํ…Œ์ŠคํŠธ 1๊ฐœ ๋‹จ์œ„์˜ Red-Green-Refactor ์‚ฌ์ดํด๋กœ ํ•ด์„๋˜๊ณ ,
PR ๋‹จ๊ณ„์—์„œ๋„ ๊ตฌ์กฐ ๋ณ€๊ฒฝ๊ณผ ๋™์ž‘ ๋ณ€๊ฒฝ์˜ ๋ถ„๋ฆฌ๋ฅผ ํ™•์ธํ•  ์ˆ˜ ์žˆ๋‹ค.

Constraint: plan.md๋Š” ์ €์žฅ์†Œ ์ „์—ญ ์‹คํ–‰ ๊ทœ์น™ ๋ฌธ์„œ์—ฌ์•ผ ํ•œ๋‹ค
Constraint: PR ๋‹จ๊ณ„์—์„œ TDD/Tidy First ์ค€์ˆ˜ ์—ฌ๋ถ€๋ฅผ ๋“œ๋Ÿฌ๋‚ด์•ผ ํ•œ๋‹ค
Rejected: ์›์น™๋งŒ ์งง๊ฒŒ ์œ ์ง€ | ์‹ค์ œ ์‹คํ–‰/๋ฆฌ๋ทฐ ๋‹จ๊ณ„์—์„œ ๊ฐ•์ œ๋ ฅ์ด ๋ถ€์กฑํ•จ
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: ์ดํ›„ ๊ธฐ๋Šฅ ์ž‘์—…์€ ๋ฐ˜๋“œ์‹œ Test Queue์˜ ์ฒซ ๋ฏธ์™„๋ฃŒ ํ•ญ๋ชฉ๋ถ€ํ„ฐ ํ•œ ํ…Œ์ŠคํŠธ์”ฉ ์ง„ํ–‰ํ•  ๊ฒƒ
Tested: plan.md ๋ฐ PR ํ…œํ”Œ๋ฆฟ diff review
Not-tested: automated checks not applicable to markdown-only policy update
Info.plist์˜ ๋งˆ์ผ€ํŒ… ๋ฒ„์ „๊ณผ ๋นŒ๋“œ ๋„˜๋ฒ„๋ฅผ ์˜ฌ๋ ค ๋‹ค์Œ ๋ฐฐํฌ/์•„์นด์ด๋ธŒ ์‹œ๋„ ๊ธฐ์ค€์„ ๋งž์ท„๋‹ค.

Constraint: Xcode archive ์‹œ ํ‘œ์‹œ๋˜๋Š” ์•ฑ ๋ฒ„์ „/๋นŒ๋“œ ์ •๋ณด๋Š” Info.plist ๊ฐ’๊ณผ ์ผ์น˜ํ•ด์•ผ ํ•œ๋‹ค
Rejected: ๋ฒ„์ „์€ ์œ ์ง€ํ•˜๊ณ  ๋นŒ๋“œ๋งŒ ์ฆ๊ฐ€ | ์‚ฌ์šฉ์ž ์š”์ฒญ์ด ๋ฒ„์ „๊ณผ ๋นŒ๋“œ ๋‘˜ ๋‹ค ์˜ฌ๋ฆฌ๋Š” ๊ฒƒ์ด์—ˆ์Œ
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: ๋‹ค์Œ ๋ฆด๋ฆฌ์ฆˆ ๋ณ€๊ฒฝ ์‹œ ๋งˆ์ผ€ํŒ… ๋ฒ„์ „๊ณผ ๋นŒ๋“œ ๋„˜๋ฒ„๋ฅผ ํ•จ๊ป˜ ๊ฒ€ํ† ํ•  ๊ฒƒ
Tested: plutil -p Projects/App/Support/Info.plist
Not-tested: archive/build execution not rerun in this step
App Store Connect ์—…๋กœ๋“œ ์˜ค๋ฅ˜๋ฅผ ํ•ด๊ฒฐํ•˜๊ธฐ ์œ„ํ•ด ๋งˆ์ผ€ํŒ… ๋ฒ„์ „์„ 2.5.1๋กœ,
๋นŒ๋“œ ๋„˜๋ฒ„๋ฅผ 101๋กœ ์˜ฌ๋ ธ๋‹ค.
์ด์ „ 2.4.1์€ ์Šน์ธ๋œ ์ตœ์‹  ๋ฒ„์ „ 2.5.0๋ณด๋‹ค ๋‚ฎ์•˜๊ณ ,
2.5.0์€ ๋” ์ด์ƒ ์ƒˆ ๋นŒ๋“œ ์ œ์ถœ์„ ๋ฐ›์„ ์ˆ˜ ์—†๋Š” ์ƒํƒœ์˜€๋‹ค.

Constraint: CFBundleShortVersionString์€ ๊ธฐ์กด ์Šน์ธ ๋ฒ„์ „๋ณด๋‹ค ๋†’์•„์•ผ ํ•œ๋‹ค
Constraint: ๋‹ซํžŒ ๋ฒ„์ „ ๋ฒˆํ˜ธ๋Š” ์ƒˆ ๋นŒ๋“œ ์—…๋กœ๋“œ์— ์žฌ์‚ฌ์šฉํ•  ์ˆ˜ ์—†๋‹ค
Rejected: 2.5.0 ์žฌ์‚ฌ์šฉ | App Store Connect์—์„œ closed for new build submissions๋กœ ๊ฑฐ์ ˆ๋จ
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: ๋‹ค์Œ ์—…๋กœ๋“œ ์ „์—๋Š” App Store Connect์˜ ์ตœ์‹  ์Šน์ธ/๋‹ซํžŒ ๋ฒ„์ „์„ ๋จผ์ € ํ™•์ธํ•  ๊ฒƒ
Tested: plutil -p Projects/App/Support/Info.plist
Not-tested: archive/upload retry not executed in this step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant