Skip to content

Keep SMB rename verification off the UI thread #4611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
venkyqz wants to merge 1 commit into
base: release/4.0
Choose a base branch
from
+3 −1
Open

Keep SMB rename verification off the UI thread #4611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/src/main/java/com/amaze/filemanager/utils/MainActivityHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,9 @@ public void done(final HybridFile hFile, final boolean b) {
* DocumentFile.renameTo() may return false even when rename is successful. Hence we need an extra check
* instead of merely looking at the return value
*/
if (b || newFile.exists(context)) {
if (b
Copy link
Copy Markdown
Member

@EmmanuelMess EmmanuelMess Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fix the issue (exists running on main thread) and seems incredibly easy to break if the implementation of Operations.rename changes (by changing how otg is handled or using DocumentFile for other file types). To fix the issue, the exists check should probably be moved to Operations.rename.

|| ((newFile.isDocumentFile() || newFile.isOtgFile())
&& newFile.exists(context))) {
Intent intent = new Intent(MainActivity.KEY_INTENT_LOAD_LIST);

intent.putExtra(
Expand Down