Introduce CMP and AboutActivity rewrite#13486
Draft
theimpulson wants to merge 23 commits into
Draft
Conversation
Building release builds is still broken on encrypted linux file systems but that's seems to be not a priority for Google to fix. Upgrade so that developers can avoid suffering from bugs such as preview rendering failure. Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
See: https://issuetracker.google.com/issues/266331465#comment21 Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Rework for multiplatform support while cleaning and making logic more modular for ease with testing individual components Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Current ones are planned to be deprecated in AGP 10.x Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
…on parameters This will make it easier to test Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
The referenced doc is outdated but the information is still relevant in some way especially the Gradle commands Ref: https://kotlinlang.org/docs/multiplatform/compose-test.html Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
This would allow us to declare compose related proguard rules for Android in this module Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
This ensures it isn't clipped when shown as squricle Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Also remove committed files that contain personal configuration Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Consuming Scaffold's padding as it is applies padding for navigation bar as well which disables drawing behind it effectively disabling edge to edge in a way. Only consume the status bar padding for top and apply navigation bar padding as content padding in LazyColumn directly Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Move important version properties to buildSrc directory to access between modules as needed. Also add a simple task to generate a simple BuildConfig class to access version name. This is better than adding dependency on a third-party library/plugin. Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Keep the model class file stricly to model Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
ShareASmile
added
code quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
net.newpipe.app)Before/After Screenshots/Screen Record
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence