Merge branch 'dev' into Refactor-Optional

# Conflicts:
#	extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeChannelHelper.java
#	extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
#	extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java

Author: Isira-Seneviratne

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampCommentsExtractor.java

@@ -114,9 +114,7 @@ private JsonObject fetchReviewsData(final String trackId, final String token)
     }
 
     private String getNextPageToken(final JsonArray reviews) throws ParsingException {
-        return reviews.stream()
-                .filter(JsonObject.class::isInstance)
-                .map(JsonObject.class::cast)
+        return reviews.streamAsJsonObjects()
                 .map(review -> review.getString("token"))
                 .reduce((a, b) -> b) // keep only the last element
                 .orElseThrow(() -> new ParsingException("Could not get token"));

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampSuggestionExtractor.java

@@ -48,9 +48,8 @@ public List<String> suggestionList(final String query) throws IOException, Extra
                                     .done()
                                     .getBytes(StandardCharsets.UTF_8)).responseBody());
 
-            return fuzzyResults.getObject("auto").getArray("results").stream()
-                    .filter(JsonObject.class::isInstance)
-                    .map(JsonObject.class::cast)
+            return fuzzyResults.getObject("auto").getArray("results")
+                    .streamAsJsonObjects()
                     .map(jsonObject -> jsonObject.getString("name"))
                     .distinct()
                     .collect(Collectors.toList());

extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCChannelTabExtractor.java

@@ -55,9 +55,7 @@ public ListExtractor.InfoItemsPage<InfoItem> getInitialPage() {
                 new MultiInfoItemsCollector(getServiceId());
         Objects.requireNonNull(conferenceData) // will surely be != null after onFetchPage
                 .getArray("events")
-                .stream()
-                .filter(JsonObject.class::isInstance)
-                .map(JsonObject.class::cast)
+                .streamAsJsonObjects()
                 .forEach(event -> collector.commit(new MediaCCCStreamInfoItemExtractor(event)));
         return new ListExtractor.InfoItemsPage<>(collector, null);
     }

extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCLiveStreamExtractor.java

@@ -145,9 +145,7 @@ public String getHlsUrl() {
 
     @Nonnull
     private String getManifestOfDeliveryMethodWanted(@Nonnull final String deliveryMethod) {
-        return room.getArray(STREAMS).stream()
-                .filter(JsonObject.class::isInstance)
-                .map(JsonObject.class::cast)
+        return room.getArray(STREAMS).streamAsJsonObjects()
                 .map(streamObject -> streamObject.getObject(URLS))
                 .filter(urls -> urls.has(deliveryMethod))
                 .map(urls -> urls.getObject(deliveryMethod).getString(URL, ""))
@@ -228,10 +226,7 @@ private static final class MediaCCCLiveStreamMapperDTO {
     private <T extends Stream> List<T> getStreams(
             @Nonnull final String streamType,
             @Nonnull final Function<MediaCCCLiveStreamMapperDTO, T> converter) {
-        return room.getArray(STREAMS).stream()
-                // Ensure that we use only process JsonObjects
-                .filter(JsonObject.class::isInstance)
-                .map(JsonObject.class::cast)
+        return room.getArray(STREAMS).streamAsJsonObjects()
                 // Only process streams of requested type
                 .filter(streamJsonObj -> streamType.equals(streamJsonObj.getString("type")))
                 // Flatmap Urls and ensure that we use only process JsonObjects

extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCRecentKiosk.java

@@ -57,9 +57,7 @@ public InfoItemsPage<StreamInfoItem> getInitialPage() throws IOException, Extrac
                 .reversed();
         final var collector = new StreamInfoItemsCollector(getServiceId(), comparator);
 
-        events.stream()
-                .filter(JsonObject.class::isInstance)
-                .map(JsonObject.class::cast)
+        events.streamAsJsonObjects()
                 .map(MediaCCCRecentKioskExtractor::new)
                 // #813 / voc/voctoweb#609 -> returns faulty data -> filter it out
                 .filter(extractor -> extractor.getDuration() > 0)

extractor/src/main/java/org/schabi/newpipe/extractor/services/peertube/PeertubeParsingHelper.java

@@ -293,9 +293,7 @@ private static List<Image> getImagesFromAvatarsOrBanners(
     private static List<Image> getImagesFromAvatarOrBannerArray(
             @Nonnull final String baseUrl,
             @Nonnull final JsonArray avatarsOrBannersArray) {
-        return avatarsOrBannersArray.stream()
-                .filter(JsonObject.class::isInstance)
-                .map(JsonObject.class::cast)
+        return avatarsOrBannersArray.streamAsJsonObjects()
                 .filter(image -> !isNullOrEmpty(image.getString("path")))
                 .map(image -> new Image(baseUrl + image.getString("path"), HEIGHT_UNKNOWN,
                         image.getInt("width", WIDTH_UNKNOWN), ResolutionLevel.UNKNOWN))

extractor/src/main/java/org/schabi/newpipe/extractor/services/peertube/extractors/PeertubeStreamExtractor.java

@@ -480,10 +480,7 @@ private void loadSubtitles() {
 
     private void extractLiveVideoStreams() throws ParsingException {
         try {
-            final JsonArray streamingPlaylists = json.getArray(STREAMING_PLAYLISTS);
-            streamingPlaylists.stream()
-                    .filter(JsonObject.class::isInstance)
-                    .map(JsonObject.class::cast)
+            json.getArray(STREAMING_PLAYLISTS).streamAsJsonObjects()
                     .map(stream -> new VideoStream.Builder()
                             .setId(String.valueOf(stream.getInt("id", -1)))
                             .setContent(stream.getString(PLAYLIST_URL, ""), true)
@@ -507,10 +504,10 @@ private void getStreams() throws ParsingException {
 
         // HLS streams
         try {
-            for (final JsonObject playlist : json.getArray(STREAMING_PLAYLISTS).stream()
-                    .filter(JsonObject.class::isInstance)
-                    .map(JsonObject.class::cast)
-                    .collect(Collectors.toList())) {
+            final var playlistStream = json.getArray(STREAMING_PLAYLISTS).streamAsJsonObjects();
+            final var it = playlistStream.iterator();
+            while (it.hasNext()) {
+                final var playlist = it.next();
                 getStreamsFromArray(playlist.getArray(FILES), playlist.getString(PLAYLIST_URL));
             }
         } catch (final Exception e) {
@@ -530,11 +527,10 @@ private void getStreamsFromArray(@Nonnull final JsonArray streams,
             */
             final boolean isInstanceUsingRandomUuidsForHlsStreams = !isNullOrEmpty(playlistUrl)
                     && playlistUrl.endsWith("-master.m3u8");
-
-            for (final JsonObject stream : streams.stream()
-                    .filter(JsonObject.class::isInstance)
-                    .map(JsonObject.class::cast)
-                    .collect(Collectors.toList())) {
+            final var streamOfStreams = streams.streamAsJsonObjects();
+            final var it = streamOfStreams.iterator();
+            while (it.hasNext()) {
+                final var stream = it.next();
 
                 // Extract stream version of streams first
                 final String url = JsonUtils.getString(stream,

extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudParsingHelper.java

@@ -383,9 +383,7 @@ public static String getInfoItemsFromApi(final MultiInfoItemsCollector collector
         }
 
         responseObject.getArray("collection")
-                .stream()
-                .filter(JsonObject.class::isInstance)
-                .map(JsonObject.class::cast)
+                .streamAsJsonObjects()
                 .forEach(searchResult -> {
                     final String kind = searchResult.getString("kind", "");
                     switch (kind) {

extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudPlaylistExtractor.java

@@ -140,9 +140,7 @@ public InfoItemsPage<StreamInfoItem> getInitialPage() {
         final List<String> ids = new ArrayList<>();
 
         playlist.getArray("tracks")
-                .stream()
-                .filter(JsonObject.class::isInstance)
-                .map(JsonObject.class::cast)
+                .streamAsJsonObjects()
                 .forEachOrdered(track -> {
                     // i.e. if full info is available
                     if (track.has("title")) {

extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudStreamExtractor.java

@@ -204,9 +204,7 @@ private String getTranscodingUrl(final String endpointUrl)
 
     private void extractAudioStreams(@Nonnull final JsonArray transcodings,
                                      final List<AudioStream> audioStreams) {
-        transcodings.stream()
-                .filter(JsonObject.class::isInstance)
-                .map(JsonObject.class::cast)
+        transcodings.streamAsJsonObjects()
                 .forEachOrdered(transcoding -> {
                     final String url = transcoding.getString("url");
                     if (isNullOrEmpty(url)) {