Skip to content

Commit d14bc59

Browse files
committed
Fix: Custom fields - Missing tags and namings
Add missing tags and improve sideload naming.
1 parent c925f5d commit d14bc59

5 files changed

Lines changed: 14 additions & 10 deletions

File tree

projects/company.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -431,8 +431,8 @@ type CompanyRequestSideload string
431431

432432
// List of possible sideload options for CompanyRequestSideload.
433433
const (
434-
CompanyRequestSideloadCompanyCustomFields CompanyRequestSideload = "customfields"
435-
CompanyRequestSideloadCompanyCustomFieldValues CompanyRequestSideload = "customfieldcompanies"
434+
CompanyRequestSideloadCustomFields CompanyRequestSideload = "customfields"
435+
CompanyRequestSideloadCustomFieldValues CompanyRequestSideload = "customfieldcompanies"
436436
)
437437

438438
// CompanyRequestFilters contains the filters for loading companies.

projects/custom_field.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -773,11 +773,14 @@ func (c CustomFieldListRequest) HTTPRequest(ctx context.Context, server string)
773773
type CustomFieldListResponse struct {
774774
request CustomFieldListRequest
775775

776+
// Meta contains the pagination information for the response.
776777
Meta struct {
777778
Page struct {
778779
HasMore bool `json:"hasMore"`
779780
} `json:"page"`
780781
} `json:"meta"`
782+
783+
// CustomFields is the list of custom fields matching the request filters.
781784
CustomFields []CustomField `json:"customfields"`
782785
}
783786

projects/custom_field_value.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -552,7 +552,7 @@ func (c CustomFieldValueGetRequest) HTTPRequest(ctx context.Context, server stri
552552
// custom field value.
553553
type CustomFieldValueGetResponse struct {
554554
// CustomFieldValue is the retrieved custom field value.
555-
CustomFieldValue CustomFieldValue
555+
CustomFieldValue CustomFieldValue `json:"customfieldValue"`
556556
}
557557

558558
// UnmarshalJSON decodes the response into the CustomFieldValue field regardless
@@ -700,15 +700,16 @@ func (c CustomFieldValueListRequest) HTTPRequest(ctx context.Context, server str
700700
type CustomFieldValueListResponse struct {
701701
request CustomFieldValueListRequest
702702

703+
// Meta contains the pagination information for the response.
703704
Meta struct {
704705
Page struct {
705706
HasMore bool `json:"hasMore"`
706707
} `json:"page"`
707-
}
708+
} `json:"meta"`
708709

709710
// CustomFieldValues is the list of custom field values returned by the
710711
// request, regardless of the underlying entity type.
711-
CustomFieldValues []CustomFieldValue
712+
CustomFieldValues []CustomFieldValue `json:"customfieldValues"`
712713
}
713714

714715
// UnmarshalJSON decodes the response into the CustomFieldValues slice

projects/project.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -651,9 +651,9 @@ type ProjectRequestSideload string
651651

652652
// List of possible sideload options for ProjectRequestSideload.
653653
const (
654-
ProjectRequestSideloadProjectCategories ProjectRequestSideload = "projectCategories"
655-
ProjectRequestSideloadProjectCustomFields ProjectRequestSideload = "customfields"
656-
ProjectRequestSideloadProjectCustomFieldValues ProjectRequestSideload = "customfieldprojects"
654+
ProjectRequestSideloadProjectCategories ProjectRequestSideload = "projectCategories"
655+
ProjectRequestSideloadCustomFields ProjectRequestSideload = "customfields"
656+
ProjectRequestSideloadCustomFieldValues ProjectRequestSideload = "customfieldprojects"
657657
)
658658

659659
// ProjectRequestFilters contains the filters for loading projects.

projects/task.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -599,8 +599,8 @@ type TaskRequestSideload string
599599

600600
// List of possible sideload options for TaskRequestSideload.
601601
const (
602-
TaskRequestSideloadTaskCustomFields TaskRequestSideload = "customfields"
603-
TaskRequestSideloadTaskCustomFieldValues TaskRequestSideload = "customfieldtasks"
602+
TaskRequestSideloadCustomFields TaskRequestSideload = "customfields"
603+
TaskRequestSideloadCustomFieldValues TaskRequestSideload = "customfieldtasks"
604604
)
605605

606606
// TaskRequestFilters contains the filters for loading tasks.

0 commit comments

Comments
 (0)