Skip to content

Fix: Timelog - Allow omitting the billable field #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafaeljusto merged 1 commit into from
Jun 22, 2026
Merged

Fix: Timelog - Allow omitting the billable field #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions projects/timelog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,9 @@ type TimelogCreateRequest struct {
// they will be summed up to calculate the total time logged.
Minutes int64 `json:"minutes"`

// Billable indicates whether the timelog is billable or not.
Billable bool `json:"isBillable"`
// Billable indicates whether the timelog is billable or not. When not
// provided, it will default to the tasklist or project settings.
Billable *bool `json:"isBillable"`

// UserID is an optional ID of the user who logged the timelog. If not
// provided, the timelog will be logged by the user making the request.
Expand Down
4 changes: 2 additions & 2 deletions projects/timelog_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func TestTimelogCreate(t *testing.T) {
IsUTC: true,
Hours: 2,
Minutes: 30,
Billable: true,
Billable: new(true),
UserID: &testResources.UserID,
TagIDs: []int64{testResources.TagID},
},
Expand All @@ -59,7 +59,7 @@ func TestTimelogCreate(t *testing.T) {
IsUTC: true,
Hours: 2,
Minutes: 30,
Billable: true,
Billable: new(true),
UserID: &testResources.UserID,
TagIDs: []int64{testResources.TagID},
},
Expand Down