[fsharp] Create new Fortune object in scope of request (#10654)

The new fortune object must be constructed in the scope of the request,
not as a constant:

> Within the scope of the request, a new Fortune object must be
constructed and added to the list.

https://github.com/TechEmpower/FrameworkBenchmarks/wiki/Project-Information-Framework-Tests-Overview#fortunes

Author: p8

frameworks/FSharp/falco/src/App/Program.fs

@@ -22,16 +22,13 @@ type Fortune =
     { id : int
       message : string }
 
-    static member Default =
-        { id = 0
-          message = "Additional fortune added at request time." }
-
 let handleFortunes (connStr : string) : HttpHandler = fun ctx -> task {
 
     use conn = new NpgsqlConnection(connStr)
     let! data = conn.QueryAsync<Fortune>("SELECT id, message FROM fortune")
     let fortunes = data.AsList()
-    fortunes.Add(Fortune.Default)
+    fortunes.Add({ id = 0
+                   message = "Additional fortune added at request time." })
 
     let sortedFortunes =
         fortunes

frameworks/FSharp/frank/src/App/Program.fs

@@ -37,7 +37,6 @@ let text' (msg:string): HttpContext -> Task =
         ctx.Response.Body.WriteAsync(bytes, 0, bytes.Length)
 
 // Pulled from Giraffe example
-let extra = { id = 0; message = "Additional fortune added at request time." }
 let fortunes' : HttpHandler = 
     fun _ ctx ->
         task {
@@ -46,7 +45,7 @@ let fortunes' : HttpHandler =
 
             let view =
                 let xs = data.AsList()
-                xs.Add extra
+                xs.Add { id = 0; message = "Additional fortune added at request time." }
                 xs.Sort FortuneComparer
                 HtmlViews.fortunes xs
 

frameworks/FSharp/giraffe/src/App/Program.fs

@@ -117,11 +117,6 @@ module HttpHandlers =
     open Dapper
     open Npgsql
 
-    let private extra = {
-        id = 0
-        message = "Additional fortune added at request time."
-    }
-
     let fortunes: HttpHandler =
         fun _ ctx ->
             task {
@@ -133,7 +128,7 @@ module HttpHandlers =
 
                 let view =
                     let xs = data.AsList ()
-                    xs.Add extra
+                    xs.Add { id = 0; message = "Additional fortune added at request time." }
                     xs.Sort FortuneComparer
                     HtmlViews.fortunes xs
 

frameworks/FSharp/oxpecker/src/App/Program.fs

@@ -10,12 +10,6 @@ module HttpHandlers =
     open SpanJson
     open Oxpecker.ViewEngine
 
-    let private extra =
-        {
-            id = 0
-            message = "Additional fortune added at request time."
-        }
-
     let private fortunesHeadAndTail =
         (fun (content: HtmlElement) ->
             html() {
@@ -35,7 +29,7 @@ module HttpHandlers =
         ) |> RenderHelpers.prerender
 
     let rec private renderFortunes (ctx: HttpContext) (data: ResizeArray<Fortune>) =
-        data.Add extra
+        data.Add { id = 0; message = "Additional fortune added at request time." }
         data.Sort FortuneComparer
         RenderHelpers.CombinedElement(fortunesHeadAndTail, data)
         |> ctx.WriteHtmlViewChunked

frameworks/FSharp/zebra/src/App/Program.fs

@@ -73,7 +73,6 @@ module View =
             ]
         ] |> compileDoc
 
-    let extra = { id = 0; message = "Additional fortune added at request time." }
     let FortuneComparer = { new IComparer<Fortune> with
         member self.Compare(a,b) = String.CompareOrdinal(a.message, b.message)
 }
@@ -98,7 +97,7 @@ let main args =
 
                 let fortunes =
                     let xs = data.AsList()
-                    xs.Add View.extra
+                    xs.Add { id = 0; message = "Additional fortune added at request time." }
                     xs.Sort View.FortuneComparer
                     xs