Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

[kotlin/ktor] Variant R2bc fail in all test, except the first.#10766

Closed
joanhey wants to merge 3 commits into
TechEmpower:masterfrom
joanhey:patch-3
Closed

[kotlin/ktor] Variant R2bc fail in all test, except the first.#10766
joanhey wants to merge 3 commits into
TechEmpower:masterfrom
joanhey:patch-3

Conversation

@joanhey
Copy link
Copy Markdown
Contributor

@joanhey joanhey commented Feb 16, 2026

Removed unused URLs and updated approach type.

This variant only work with the first bench (db) and later do nothing.

I wanted to delete only the tests than fail, but I left the first one, the db test.
But later I marked as Stripped, because a fw need to return a response good or bad.
And this variant return nothing:

https://tfb-status.techempower.com/unzip/results.2026-02-03-23-09-26-607.zip/results/20260127014105/ktor-r2dbc/json/raw.txt
https://tfb-status.techempower.com/unzip/results.2026-02-03-23-09-26-607.zip/results/20260127014105/ktor-r2dbc/query/raw.txt
https://tfb-status.techempower.com/unzip/results.2026-02-03-23-09-26-607.zip/results/20260127014105/ktor-r2dbc/fortune/raw.txt
...

Return nothing, but the run need the time to bench it !!
A fw need to return a response good or bad, for that I marked it as Stripped.

But @msmith-techempower will decide it.

Ping: @ShreckYe @inemtsev please fix it and add a maintainer in the benchmark_config.json.
Thank you !!

Removed unused URLs and updated approach type.
@joanhey
Copy link
Copy Markdown
Contributor Author

joanhey commented Feb 16, 2026

😒 about the test here !!!

@joanhey joanhey changed the title [kotlin] Variant R2bc fail in all test, except the first. [kotlin/ktor] Variant R2bc fail in all test, except the first. Feb 16, 2026
@ShreckYe
Copy link
Copy Markdown
Contributor

ShreckYe commented Feb 17, 2026

Thanks for notifying. I checked that the ktor-exposed-r2dbc-dsl I maintain works fine, and I have sumitted a PR #10768 to add myself as a maintainer. The R2DBC variant was added by @inemtsev and I only tweaked the GC parameters as I recall.

cc @e5l would you mind adding maintainer info too for the original Ktor benchmark portions?

@ShreckYe
Copy link
Copy Markdown
Contributor

ShreckYe commented Feb 17, 2026

BTW, I also ran ./tfb --test ktor-r2dbc (commit 4b2a2ee) and it works on my device:

================================================================================
Verification Summary
--------------------------------------------------------------------------------
| ktor-r2dbc
|       db            : PASS
|       json          : PASS
|       query         : PASS
|       update        : PASS
|       fortune       : PASS
|       plaintext     : PASS
================================================================================

@ShreckYe
Copy link
Copy Markdown
Contributor

ShreckYe commented Feb 17, 2026

Taking a brief look, this might be the reason. If the db goes through a short hang the 5 second timeout might cause the app to fail. However, I am not 100% sure this is the only potential reason.

@inemtsev
Copy link
Copy Markdown
Contributor

I suspect it works locally because concurrency is not high enough to kill it. I will investigate a bit later today.

@joanhey
Copy link
Copy Markdown
Contributor Author

joanhey commented Feb 19, 2026

Fixed in #10790.

But we need to check it in the next run.

@joanhey joanhey closed this Feb 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants