Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

[Dart3] fix dart3_aot regression#10835

Merged
msmith-techempower merged 4 commits into
TechEmpower:masterfrom
iapicca:dart3_aot_regression_fix
Mar 2, 2026
Merged

[Dart3] fix dart3_aot regression#10835
msmith-techempower merged 4 commits into
TechEmpower:masterfrom
iapicca:dart3_aot_regression_fix

Conversation

@iapicca
Copy link
Copy Markdown
Contributor

@iapicca iapicca commented Mar 2, 2026

Summary

This PR resolves a significant performance regression in the dart-aot benchmark (Regression Trace vs Baseline).
The regression was inadvertently introduced during a previous attempt to simplify the codebase for better readability.
These changes restore the optimized isolate initialization pattern while maintaining the improved code architecture.

Changes

  • Restored the async/await handshake during main and isolate startup to ensure full CPU saturation under load.
  • Reinstated the _requestTimeout and error boundaries to prevent stalled connections from blocking the isolate event loop.
  • Applied identical updates to the dart3_native implementation.

Interestingly, while the native version appeared unaffected by the logic that regressed AOT, mirroring the code ensures a strict 1-to-1 architectural comparison between the two implementations.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 2, 2026

The following frameworks were updated, pinging maintainers:
dart3: @iapicca

@msmith-techempower msmith-techempower merged commit 8fc13af into TechEmpower:master Mar 2, 2026
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants