[refactor/#370] Activity ReadPost 슬라이스 분리 및 문서 정리#373
Merged
Conversation
Constraint: PR #370의 리팩터링 결과와 설계 문서가 같은 용어/패키지 구조를 가리켜야 함 Rejected: ReadPost 동시성 이슈까지 함께 문서화 | 별도 후속 이슈 범위라 이번 PR 설명을 흐림 Confidence: high Scope-risk: narrow Directive: SearchHistory 슬라이스가 분리되면 Activity 문서의 남은 서비스/통합 테스트 설명을 다시 갱신할 것 Tested: 문서 링크/패키지명/테스트명 정합성 점검 Not-tested: 실행 결과 자체는 문서 변경 후 재실행하지 않음
Dimo-2562
added
🌟 REFACTOR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ 기능 설명
ReadPost를domain/activity/readpost/...슬라이스로 분리했습니다.ReadPostCommandService,ReadPostQueryService,ReadPostConverter,ReadPostFirstReadPolicy로 읽기 저장/조회/첫 읽기 판별 책임을 정리했습니다.SearchHistory는 기존ActivityCommandService에 남기고, 통합 테스트도ReadPostIntegrationTest와ActivityControllerIntegrationTest(SearchHistory 전용)로 분리했습니다.docs/ddd-test-refactoring-roadmap.md,docs/test-gap-analysis.md,docs/ubiquitous-language/activity.md,docs/tactical-design.md를 현재 브랜치 구조 기준으로 갱신했습니다.테스트
./gradlew test --tests "com.techfork.domain.activity.readpost.domain.ReadPostFirstReadPolicyTest" --tests "com.techfork.domain.activity.readpost.service.ReadPostCommandServiceTest" --tests "com.techfork.domain.activity.readpost.service.ReadPostQueryServiceTest" --tests "com.techfork.domain.activity.readpost.repository.ReadPostRepositoryTest"./gradlew integrationTest --tests "com.techfork.domain.activity.readpost.integration.ReadPostIntegrationTest"./gradlew test --tests "com.techfork.domain.activity.readpost.domain.ReadPostFirstReadPolicyTest" --tests "com.techfork.domain.activity.readpost.service.ReadPostCommandServiceTest"./gradlew integrationTest --tests "com.techfork.domain.activity.readpost.integration.ReadPostIntegrationTest" --tests "com.techfork.domain.activity.controller.ActivityControllerIntegrationTest" --tests "com.techfork.domain.activity.bookmark.integration.BookmarkIntegrationTest"연결된 issue
close #370
🩷 Approve 하기 전 확인해주세요!
ReadPostFirstReadPolicy를readpost/domain으로 분리한 방향과Command/Query경계가 적절한지 봐주세요.SearchHistory를 이번 PR 범위 밖으로 두고ActivityCommandService에 남긴 의도가 괜찮은지 봐주세요.✅ 체크리스트