Auto detect compression by magic numbers#17
Open
kayoub5 wants to merge 2 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 72.96% 72.91% -0.05%
==========================================
Files 17 17
Lines 1080 1093 +13
==========================================
+ Hits 788 797 +9
- Misses 292 296 +4
Continue to review full report at Codecov.
|
LarsVoelker
requested changes
Nov 25, 2021
Member
LarsVoelker
left a comment
LarsVoelker
left a comment
There was a problem hiding this comment.
We should add a bit of more comments for the signatures and adding the gzip signature 0x1f 0x8b.
| return NULL; | ||
| #endif | ||
| } | ||
| if ((signature & 0xff000000) == 0x78000000) { |
Member
There was a problem hiding this comment.
I think we might be missing: 1F 8B for gzipped files, don't we?
| if (signature == 0x0a0d0d0a) { | ||
| return light_io_file_open(filename, mode); | ||
| } | ||
| if (signature == 0x28b52ffd || signature == 0x25b52ffd || signature == 0xfd2fb528) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.