Removed unnecessary helpers

Author: zbalkan

TechnitiumLibrary.UnitTests/TechnitiumLibrary.IO/JointTests.cs

@@ -116,8 +116,8 @@ public async Task Dispose_ShouldCloseStreams()
             await WaitForCopyCompletion();
 
             // THEN
-            Assert.ThrowsExactly<ObjectDisposedException>(() => { long _ = s1.Length; });
-            Assert.ThrowsExactly<ObjectDisposedException>(() => { long _ = s2.Length; });
+            Assert.ThrowsExactly<ObjectDisposedException>(() => { _ = s1.Length; });
+            Assert.ThrowsExactly<ObjectDisposedException>(() => { _ = s2.Length; });
         }
 
         [TestMethod]

TechnitiumLibrary.UnitTests/TechnitiumLibrary.IO/PackageItemTests.cs

@@ -298,7 +298,7 @@ public void Parse_ShouldThrow_WhenVersionIsUnsupported()
 
             Assert.ThrowsExactly<IOException>(() =>
             {
-                PackageItem _ = PackageItem.Parse(buffer);
+                _ = PackageItem.Parse(buffer);
             });
         }
 

TechnitiumLibrary.UnitTests/TechnitiumLibrary.IO/PackageTests.cs

@@ -9,8 +9,6 @@ namespace TechnitiumLibrary.UnitTests.TechnitiumLibrary.IO
     [TestClass]
     public sealed class PackageTests
     {
-        private static MemoryStream CreateWritableStream() => new MemoryStream();
-
         private static byte[] BuildEmptyPackageFile()
         {
             // Header:
@@ -23,49 +21,14 @@ private static byte[] BuildEmptyPackageFile()
                 .ToArray();
         }
 
-        /// <summary>
-        /// Creates a serialized single PackageItem with name "A" and empty content.
-        /// </summary>
-        private static byte[] CreateMinimalItem()
-        {
-            using MemoryStream ms = new MemoryStream();
-            using BinaryWriter writer = new BinaryWriter(ms);
-
-            // Write NAME field (short)
-            writer.Write((byte)1);          // length
-            writer.Write("A"u8.ToArray());  // ASCII name
-
-            // Extract location = 0
-            writer.Write((byte)0);
-
-            // Flags = 0
-            writer.Write((byte)0);
-
-            // File size = 0 (Int64)
-            writer.Write((long)0);
-
-            // Because file size = 0, Write no content
-            return ms.ToArray();
-        }
-
-        private static void WriteItem(Stream stream)
-        {
-            using MemoryStream data = new MemoryStream(); // empty payload
-            using PackageItem item = new PackageItem("A", data);
-
-            item.WriteTo(stream);
-        }
-
-
-
         // -------------------------------------------------------------
         // CONSTRUCTION
         // -------------------------------------------------------------
 
         [TestMethod]
         public void Constructor_ShouldWriteHeader_WhenCreating()
         {
-            using MemoryStream backing = CreateWritableStream();
+            using MemoryStream backing = new MemoryStream();
 
             using (Package pkg = new Package(backing, PackageMode.Create))
             {
@@ -119,12 +82,12 @@ public void AddItem_ShouldThrow_WhenNotInCreateMode()
         [TestMethod]
         public void Items_ShouldThrow_WhenNotInOpenMode()
         {
-            using MemoryStream backing = CreateWritableStream();
+            using MemoryStream backing = new MemoryStream();
             using Package pkg = new Package(backing, PackageMode.Create);
 
             Assert.ThrowsExactly<IOException>(() =>
             {
-                System.Collections.ObjectModel.ReadOnlyCollection<PackageItem> _ = pkg.Items;
+                _ = pkg.Items;
             });
         }
 
@@ -135,12 +98,12 @@ public void Items_ShouldThrow_WhenNotInOpenMode()
         [TestMethod]
         public void WriteAndRead_ShouldReturnSameItems()
         {
-            using MemoryStream backing = CreateWritableStream();
+            using MemoryStream backing = new MemoryStream();
 
             // Write
             using (Package pkg = new Package(backing, PackageMode.Create))
             {
-                WriteItem(backing);
+                pkg.AddItem(new PackageItem("A", Stream.Null));
                 pkg.Close();
             }
 
@@ -154,9 +117,9 @@ public void WriteAndRead_ShouldReturnSameItems()
         [TestMethod]
         public void Close_ShouldWriteEOF_Once()
         {
-            using MemoryStream backing = CreateWritableStream();
+            using MemoryStream backing = new MemoryStream();
             using Package pkg = new Package(backing, PackageMode.Create);
-            WriteItem(backing);
+            pkg.AddItem(new PackageItem("A", Stream.Null));
             pkg.Close();
             long len1 = backing.Length;
             pkg.Close();
@@ -202,7 +165,7 @@ public void Dispose_ShouldCloseOwnedStream()
         [TestMethod]
         public void Dispose_ShouldNotCloseExternalStream()
         {
-            using MemoryStream backing = CreateWritableStream();
+            using MemoryStream backing = new MemoryStream();
             using (Package pkg = new Package(backing, PackageMode.Create, ownsStream: false))
                 pkg.Close();