Skip to content

Commit ee59f56

Browse files
zbalkanzbalkan
committed
Removed unnecessary helper
1 parent e1b6f64 commit ee59f56

File tree

1 file changed

+30
-32
lines changed

1 file changed

+30
-32
lines changed

‎TechnitiumLibrary.UnitTests/TechnitiumLibrary.IO/OffsetStreamTests.cs‎

Lines changed: 30 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ namespace TechnitiumLibrary.UnitTests.TechnitiumLibrary.IO
99
[TestClass]
1010
public sealed class OffsetStreamTests
1111
{
12-
private static MemoryStream CreateStream(byte[] data) => new MemoryStream(data, writable: true);
13-
1412
public TestContext TestContext { get; set; } = null!;
1513

1614

@@ -22,10 +20,10 @@ public sealed class OffsetStreamTests
2220
public void Constructor_ShouldExposeCorrectBasicProperties()
2321
{
2422
// GIVEN
25-
MemoryStream source = CreateStream(new byte[] { 1, 2, 3, 4, 5 });
23+
using MemoryStream source = new MemoryStream(new byte[] { 1, 2, 3, 4, 5 }, writable: true);
2624

2725
// WHEN
28-
OffsetStream offsetStream = new OffsetStream(source, offset: 1, length: 3);
26+
using OffsetStream offsetStream = new OffsetStream(source, offset: 1, length: 3);
2927

3028
// THEN
3129
Assert.AreEqual(3, offsetStream.Length);
@@ -38,10 +36,10 @@ public void Constructor_ShouldExposeCorrectBasicProperties()
3836
public void Constructor_ShouldRespectReadOnlyFlag()
3937
{
4038
// GIVEN
41-
MemoryStream source = CreateStream(new byte[10]);
39+
using MemoryStream source = new MemoryStream(new byte[10], writable: true);
4240

4341
// WHEN
44-
OffsetStream offsetStream = new OffsetStream(source, readOnly: true);
42+
using OffsetStream offsetStream = new OffsetStream(source, readOnly: true);
4543

4644
// THEN
4745
Assert.IsFalse(offsetStream.CanWrite);
@@ -55,8 +53,8 @@ public void Constructor_ShouldRespectReadOnlyFlag()
5553
public void Read_ShouldReturnSegmentWithinBounds()
5654
{
5755
// GIVEN
58-
MemoryStream source = CreateStream(new byte[] { 10, 20, 30, 40, 50 });
59-
OffsetStream offsetStream = new OffsetStream(source, offset: 1, length: 3);
56+
using MemoryStream source = new MemoryStream(new byte[] { 10, 20, 30, 40, 50 }, writable: true);
57+
using OffsetStream offsetStream = new OffsetStream(source, offset: 1, length: 3);
6058

6159
byte[] buffer = new byte[10];
6260

@@ -72,8 +70,8 @@ public void Read_ShouldReturnSegmentWithinBounds()
7270
public void Read_ShouldReturnZero_WhenPastLength()
7371
{
7472
// GIVEN
75-
MemoryStream source = CreateStream(new byte[] { 1, 2, 3, 4 });
76-
OffsetStream offsetStream = new OffsetStream(source, offset: 2, length: 1);
73+
using MemoryStream source = new MemoryStream(new byte[] { 1, 2, 3, 4 }, writable: true);
74+
using OffsetStream offsetStream = new OffsetStream(source, offset: 2, length: 1);
7775

7876
byte[] buffer = new byte[5];
7977
offsetStream.Position = 1;
@@ -89,8 +87,8 @@ public void Read_ShouldReturnZero_WhenPastLength()
8987
public void ReadAsync_ShouldReturnCorrectData()
9088
{
9189
// GIVEN
92-
MemoryStream source = CreateStream(new byte[] { 9, 8, 7, 6 });
93-
OffsetStream offsetStream = new OffsetStream(source, offset: 1, length: 2);
90+
using MemoryStream source = new MemoryStream(new byte[] { 9, 8, 7, 6 }, writable: true);
91+
using OffsetStream offsetStream = new OffsetStream(source, offset: 1, length: 2);
9492
byte[] buffer = new byte[10];
9593

9694
// WHEN
@@ -109,8 +107,8 @@ public void ReadAsync_ShouldReturnCorrectData()
109107
public void Write_ShouldPlaceDataAtOffset()
110108
{
111109
// GIVEN
112-
MemoryStream source = CreateStream(new byte[] { 1, 2, 3, 4 });
113-
OffsetStream offsetStream = new OffsetStream(source, offset: 1, length: 2);
110+
using MemoryStream source = new MemoryStream(new byte[] { 1, 2, 3, 4 }, writable: true);
111+
using OffsetStream offsetStream = new OffsetStream(source, offset: 1, length: 2);
114112

115113
// WHEN
116114
offsetStream.Write("23"u8.ToArray(), 0, 2);
@@ -123,8 +121,8 @@ public void Write_ShouldPlaceDataAtOffset()
123121
public void Write_ShouldExtendLength()
124122
{
125123
// GIVEN
126-
MemoryStream source = CreateStream(new byte[] { 1, 2, 3 });
127-
OffsetStream offsetStream = new OffsetStream(source, offset: 0, length: 2);
124+
using MemoryStream source = new MemoryStream(new byte[] { 1, 2, 3 }, writable: true);
125+
using OffsetStream offsetStream = new OffsetStream(source, offset: 0, length: 2);
128126

129127
// WHEN
130128
offsetStream.Position = 2;
@@ -138,8 +136,8 @@ public void Write_ShouldExtendLength()
138136
public void Write_ShouldThrow_WhenReadOnly()
139137
{
140138
// GIVEN
141-
MemoryStream source = CreateStream(new byte[] { 1, 2, 3 });
142-
OffsetStream offsetStream = new OffsetStream(source, readOnly: true);
139+
using MemoryStream source = new MemoryStream(new byte[] { 1, 2, 3 }, writable: true);
140+
using OffsetStream offsetStream = new OffsetStream(source, readOnly: true);
143141

144142
// WHEN–THEN
145143
Assert.ThrowsExactly<InvalidOperationException>(() =>
@@ -154,8 +152,8 @@ public void Write_ShouldThrow_WhenReadOnly()
154152
public void Seek_ShouldMoveWithinValidRange()
155153
{
156154
// GIVEN
157-
MemoryStream source = CreateStream(new byte[] { 1, 2, 3, 4 });
158-
OffsetStream offsetStream = new OffsetStream(source, offset: 0, length: 4);
155+
using MemoryStream source = new MemoryStream(new byte[] { 1, 2, 3, 4 }, writable: true);
156+
using OffsetStream offsetStream = new OffsetStream(source, offset: 0, length: 4);
159157

160158
// WHEN
161159
long newPos = offsetStream.Seek(2, SeekOrigin.Begin);
@@ -169,8 +167,8 @@ public void Seek_ShouldMoveWithinValidRange()
169167
public void Seek_ShouldThrow_WhenSeekingPastEnd()
170168
{
171169
// GIVEN
172-
MemoryStream source = CreateStream(new byte[] { 1, 2, 3 });
173-
OffsetStream offsetStream = new OffsetStream(source, offset: 0, length: 3);
170+
using MemoryStream source = new MemoryStream(new byte[] { 1, 2, 3 }, writable: true);
171+
using OffsetStream offsetStream = new OffsetStream(source, offset: 0, length: 3);
174172

175173
// WHEN–THEN
176174
Assert.ThrowsExactly<EndOfStreamException>(() =>
@@ -185,8 +183,8 @@ public void Seek_ShouldThrow_WhenSeekingPastEnd()
185183
public void Dispose_ShouldCloseBaseStream_WhenOwnsStream()
186184
{
187185
// GIVEN
188-
MemoryStream source = CreateStream(new byte[] { 1 });
189-
OffsetStream offsetStream = new OffsetStream(source, ownsStream: true);
186+
using MemoryStream source = new MemoryStream(new byte[] { 1 }, writable: true);
187+
using OffsetStream offsetStream = new OffsetStream(source, ownsStream: true);
190188

191189
// WHEN
192190
offsetStream.Dispose();
@@ -199,8 +197,8 @@ public void Dispose_ShouldCloseBaseStream_WhenOwnsStream()
199197
public void Dispose_ShouldNotCloseBaseStream_WhenNotOwned()
200198
{
201199
// GIVEN
202-
MemoryStream source = CreateStream(new byte[] { 1 });
203-
OffsetStream offsetStream = new OffsetStream(source, ownsStream: false);
200+
using MemoryStream source = new MemoryStream(new byte[] { 1 }, writable: true);
201+
using OffsetStream offsetStream = new OffsetStream(source, ownsStream: false);
204202

205203
// WHEN
206204
offsetStream.Dispose();
@@ -217,9 +215,9 @@ public void Dispose_ShouldNotCloseBaseStream_WhenNotOwned()
217215
public void WriteTo_ShouldCopyOnlyOffsetRange()
218216
{
219217
// GIVEN
220-
MemoryStream source = CreateStream(new byte[] { 10, 20, 30, 40 });
221-
OffsetStream offsetStream = new OffsetStream(source, offset: 1, length: 2);
222-
MemoryStream target = new MemoryStream();
218+
using MemoryStream source = new MemoryStream(new byte[] { 10, 20, 30, 40 }, writable: true);
219+
using OffsetStream offsetStream = new OffsetStream(source, offset: 1, length: 2);
220+
using MemoryStream target = new MemoryStream();
223221

224222
// WHEN
225223
offsetStream.WriteTo(target);
@@ -232,9 +230,9 @@ public void WriteTo_ShouldCopyOnlyOffsetRange()
232230
public async Task WriteToAsync_ShouldCopyOnlyOffsetRange()
233231
{
234232
// GIVEN
235-
MemoryStream source = CreateStream("2<F"u8.ToArray());
236-
OffsetStream offsetStream = new OffsetStream(source, offset: 1, length: 2);
237-
MemoryStream target = new MemoryStream();
233+
using MemoryStream source = new MemoryStream("2<F"u8.ToArray(), writable: true);
234+
using OffsetStream offsetStream = new OffsetStream(source, offset: 1, length: 2);
235+
using MemoryStream target = new MemoryStream();
238236

239237
// WHEN
240238
await offsetStream.WriteToAsync(target);

0 commit comments

Comments
 (0)