Skip to content

Commit 77baf0e

Browse files
committed
Fix macOS entitlements and Windows code signing for CI builds
1 parent 9a06d02 commit 77baf0e

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

.github/workflows/release.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,12 @@ jobs:
7272
shell: bash
7373
env:
7474
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
75-
# macOS code signing (optional)
76-
CSC_LINK: ${{ secrets.CSC_LINK }}
77-
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
78-
# Windows code signing (optional)
75+
# Code signing is opt-in via repo secrets. When secrets are
76+
# absent we explicitly blank the env vars so electron-builder
77+
# doesn't try to resolve a non-existent certificate path.
78+
CSC_LINK: ${{ secrets.CSC_LINK || '' }}
79+
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD || '' }}
80+
WIN_CSC_LINK: ${{ secrets.WIN_CSC_LINK || '' }}
7981
CSC_IDENTITY_AUTO_DISCOVERY: 'false'
8082
run: npm run build:${{ matrix.script }}
8183

package.json

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,12 +85,10 @@
8585
]
8686
}
8787
],
88-
"icon": "assets/icons/app-icon.icns",
88+
"icon": "assests/icons/app-icon.icns",
8989
"darkModeSupport": true,
90-
"hardenedRuntime": true,
91-
"gatekeeperAssess": false,
92-
"entitlements": "build/entitlements.mac.plist",
93-
"entitlementsInherit": "build/entitlements.mac.plist"
90+
"hardenedRuntime": false,
91+
"gatekeeperAssess": false
9492
},
9593
"win": {
9694
"target": [
@@ -109,7 +107,7 @@
109107
]
110108
}
111109
],
112-
"icon": "assets/icons/app-icon.ico"
110+
"icon": "assests/icons/app-icon.ico"
113111
},
114112
"linux": {
115113
"target": [

0 commit comments

Comments
 (0)