Skip to content

Commit c38f80c

Browse files
committed
Remove CSC env vars, icon configs, and identity to fix CI build
1 parent 77baf0e commit c38f80c

2 files changed

Lines changed: 9 additions & 15 deletions

File tree

.github/workflows/release.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,12 @@ jobs:
7272
shell: bash
7373
env:
7474
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
75-
# Code signing is opt-in via repo secrets. When secrets are
76-
# absent we explicitly blank the env vars so electron-builder
77-
# doesn't try to resolve a non-existent certificate path.
78-
CSC_LINK: ${{ secrets.CSC_LINK || '' }}
79-
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD || '' }}
80-
WIN_CSC_LINK: ${{ secrets.WIN_CSC_LINK || '' }}
75+
# Intentionally do NOT set CSC_LINK / WIN_CSC_LINK etc.
76+
# electron-builder treats empty strings as "set but invalid"
77+
# and tries to resolve them as certificate paths, producing
78+
# "Env WIN_CSC_LINK is not correct" errors. Code signing is
79+
# opt-in: add the secrets to the repo and wire them in here
80+
# only when you have real certificates.
8181
CSC_IDENTITY_AUTO_DISCOVERY: 'false'
8282
run: npm run build:${{ matrix.script }}
8383

package.json

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,6 @@
6161
"!.whisper-models/**/*",
6262
"!eng.traineddata"
6363
],
64-
"extraFiles": [
65-
"prompts/**/*"
66-
],
67-
"asarUnpack": [
68-
"node_modules/**/*"
69-
],
7064
"mac": {
7165
"category": "public.app-category.utilities",
7266
"target": [
@@ -85,7 +79,6 @@
8579
]
8680
}
8781
],
88-
"icon": "assests/icons/app-icon.icns",
8982
"darkModeSupport": true,
9083
"hardenedRuntime": false,
9184
"gatekeeperAssess": false
@@ -107,7 +100,8 @@
107100
]
108101
}
109102
],
110-
"icon": "assests/icons/app-icon.ico"
103+
"sign": null,
104+
"signtoolOptions": null
111105
},
112106
"linux": {
113107
"target": [
@@ -124,7 +118,7 @@
124118
]
125119
}
126120
],
127-
"icon": "assets/icons/app-icon.png",
121+
"icon": "assests/icons/app-icon.png",
128122
"category": "Utility"
129123
},
130124
"deb": {

0 commit comments

Comments
 (0)