Fix clang/llvm#40
Merged
Merged
Conversation
david-banon-tecnativa
left a comment
david-banon-tecnativa
left a comment
Contributor
There was a problem hiding this comment.
Hi, thanks for putting the work into this, i would rather search for existing pks than use a hardcoded loop. ¿Do you see any issue with searching the pkg with something like this?
Contributor
Author
|
@david-banon-tecnativa, please take another look. I discovered that there was a lot more to this problem and have done the best I could to fix it |
david-banon-tecnativa
left a comment
david-banon-tecnativa
left a comment
Contributor
There was a problem hiding this comment.
Looks good, some minor comments before approving and merging.
| RUN apk add --no-cache python3 py3-netifaces \ | ||
| && if [ "${PG_MAJOR:-0}" -ge 12 ]; then \ | ||
| apk add --no-cache --virtual .pgvector-build build-base clang19 llvm19 linux-headers ca-certificates; \ | ||
| && if [ "${PG_MAJOR:-0}" -ge 13 ]; then \ |
Contributor
There was a problem hiding this comment.
Can the PG version bump go in a separate commit? Thanks for catching this, PGVector 8.x no longer supports pg 12
Base for Postgres 14-18 was bumped from alpine v3.23 to v3.24 in docker-library/official-images@769849f Alpine v3.24 dropped support for clang19/llvm19, which caused pgvector-build to fail for versions 14 and up. As it turns out, using hardcoded clang19/llvm19 was already not the best idea as it did not match the version used by postgres itself. Only postgres 13 uses clang19 and llvm19, everything above uses clang21 and llvm21. Also, pgvector 0.8.1 does not support pg12 https://github.com/pgvector/pgvector/blob/fb1b8966ebb9254032b6d0e7a594fdcc86f8efcc/CHANGELOG.md?plain=1#L34 Ultimately, I beleive pgvector was only properly installed in a few versions. This commit makes sure it is installed from 13 upwards and also tests that it is installed and working.
david-banon-tecnativa
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base for Postgres 14-18 was bumped from alpine v3.23 to v3.24 in docker-library/official-images@769849f
Alpine v3.24 dropped support for clang19/llvm19, which caused pgvector-build to fail for versions 14 and up.
On investigation, it turns out that it was impossible to use just one version of clang and llvm because in alpine-12 the highest version is still clang19.
The simplest solution is to just loop over the versions from the top down. I even added version 23, which does not exist yet, but will defer the necessity of doing this again for a while