Merge pull request #59 from Ted-Jin-Lab/development

✨New QuantityImplicitToValueTypeAttribute

Author: Ted-Jin-Lab

Directory.Build.props

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project>
   <PropertyGroup>
-    <Version>2025.11.19.5</Version>
+    <Version>2025.11.19.6</Version>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <LangVersion>preview</LangVersion>

Tests/TedToolkit.Console/Absorptance.cs

@@ -1,5 +1,6 @@
 namespace TedToolkit.Quantities;
 
+[QuantityImplicitToValueType]
 [QuantityOperator<AbsorbedDose, AbsorbedDose, double>(Operator.Divide)]
 partial struct AbsorbedDose
 {
@@ -8,5 +9,6 @@ public static void Test()
         var a = new AbsorbedDose(10, AbsorbedDoseUnit.Centigray);
         var b = new AbsorbedDose(10, AbsorbedDoseUnit.Centigray);
         var c = a / b;
+        double d = a;
     }
 }

src/analyzers/TedToolkit.Quantities.Analyzer/QuantityStructGenerator.cs

@@ -21,25 +21,6 @@ public void GenerateCode(SourceProductionContext context)
     {
         List<MemberDeclarationSyntax> operators = [];
 
-        if (!quantity.IsNoDimensions)
-        {
-            operators.Add(
-                OperatorDeclaration(IdentifierName(quantity.Name), Token(SyntaxKind.AsteriskToken))
-                    .WithModifiers(TokenList(Token(SyntaxKind.PublicKeyword),
-                        Token(SyntaxKind.StaticKeyword)))
-                    .WithAttributeLists([GeneratedCodeAttribute(typeof(QuantityStructGenerator))])
-                    .WithParameterList(ParameterList(
-                    [
-                        Parameter(Identifier("left")).WithType(IdentifierName(typeName.FullName)),
-                        Parameter(Identifier("right")).WithType(IdentifierName(quantity.Name)),
-                    ]))
-                    .WithExpressionBody(ArrowExpressionClause(
-                        BinaryExpression(SyntaxKind.MultiplyExpression,
-                            IdentifierName("right"),
-                            IdentifierName("left"))))
-                    .WithSemicolonToken(Token(SyntaxKind.SemicolonToken)));
-        }
-
         if (quantitySymbol is not null)
         {
             foreach (var attributeData in quantitySymbol.GetAttributes()
@@ -461,7 +442,8 @@ public void GenerateCode(SourceProductionContext context)
                         #region Conversions
 
                         ConversionOperatorDeclaration(
-                                Token(quantity.IsNoDimensions
+                                Token(quantitySymbol?.GetAttributes().Any(a => a.AttributeClass?.GetName().FullName 
+                                    is "global::TedToolkit.Quantities.QuantityImplicitToValueTypeAttribute") ?? false
                                     ? SyntaxKind.ImplicitKeyword
                                     : SyntaxKind.ExplicitKeyword),
                                 IdentifierName(typeName.FullName)).WithModifiers(TokenList(
@@ -670,7 +652,7 @@ public void GenerateCode(SourceProductionContext context)
                                         ])),
                                     LiteralExpression(SyntaxKind.NumericLiteralExpression, Literal(0)))))
                             .WithSemicolonToken(Token(SyntaxKind.SemicolonToken)),
-                        
+
                         OperatorDeclaration(PredefinedType(Token(SyntaxKind.BoolKeyword)),
                                 Token(SyntaxKind.LessThanToken))
                             .WithModifiers(TokenList(Token(SyntaxKind.PublicKeyword), Token(SyntaxKind.StaticKeyword)))
@@ -714,7 +696,7 @@ public void GenerateCode(SourceProductionContext context)
                                         ])),
                                     LiteralExpression(SyntaxKind.NumericLiteralExpression, Literal(0)))))
                             .WithSemicolonToken(Token(SyntaxKind.SemicolonToken)),
-                        
+
                         OperatorDeclaration(PredefinedType(Token(SyntaxKind.BoolKeyword)),
                                 Token(SyntaxKind.LessThanEqualsToken))
                             .WithModifiers(TokenList(Token(SyntaxKind.PublicKeyword), Token(SyntaxKind.StaticKeyword)))
@@ -736,6 +718,7 @@ public void GenerateCode(SourceProductionContext context)
                                         ])),
                                     LiteralExpression(SyntaxKind.NumericLiteralExpression, Literal(0)))))
                             .WithSemicolonToken(Token(SyntaxKind.SemicolonToken)),
+
                         #endregion
 
                         #region Operators
@@ -829,6 +812,21 @@ public void GenerateCode(SourceProductionContext context)
                                     IdentifierName("right"))))))
                             .WithSemicolonToken(Token(SyntaxKind.SemicolonToken)),
 
+                        OperatorDeclaration(IdentifierName(quantity.Name), Token(SyntaxKind.AsteriskToken))
+                            .WithModifiers(TokenList(Token(SyntaxKind.PublicKeyword),
+                                Token(SyntaxKind.StaticKeyword)))
+                            .WithAttributeLists([GeneratedCodeAttribute(typeof(QuantityStructGenerator))])
+                            .WithParameterList(ParameterList(
+                            [
+                                Parameter(Identifier("left")).WithType(IdentifierName(typeName.FullName)),
+                                Parameter(Identifier("right")).WithType(IdentifierName(quantity.Name)),
+                            ]))
+                            .WithExpressionBody(ArrowExpressionClause(
+                                BinaryExpression(SyntaxKind.MultiplyExpression,
+                                    IdentifierName("right"),
+                                    IdentifierName("left"))))
+                            .WithSemicolonToken(Token(SyntaxKind.SemicolonToken)),
+
                         ..operators,
 
                         #endregion

src/libraries/TedToolkit.Quantities/QuantityImplicitToValueTypeAttribute.cs

@@ -0,0 +1,6 @@
+using System.Diagnostics.CodeAnalysis;
+
+namespace TedToolkit.Quantities;
+[AttributeUsage(AttributeTargets.Struct)]
+[SuppressMessage("ReSharper", "UnusedTypeParameter")]
+public sealed class QuantityImplicitToValueTypeAttribute: Attribute;