Skip to content

feat(go-critic): Fallback to 'gocritic' if 'go-critic' not found #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TekWizely wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(go-critic): Fallback to 'gocritic' if 'go-critic' not found #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion go-critic.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
#!/usr/bin/env bash
cmd=(go-critic check)

# Default to newer name
# If not found, but old name found, us it

@mcdonnnj mcdonnnj Mar 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor typo I noticed while reviewing.

Suggested change
# If not found, but old name found, us it
# If not found, but old name found, use it

# If neither found, leave newer for error reporting
gocritic_bin='go-critic'
if ! command -v go-critic &> /dev/null && command -v gocritic &> /dev/null; then
gocritic_bin='gocritic'
fi

cmd=("${gocritic_bin}" check)
. "$(dirname "${0}")/lib/cmd-files.bash"