Skip to content

Commit e21e46d

Browse files
edjeechrome-bot
authored andcommitted
keygeneration: make the certificates valid for 10 years
UEFI firmware implementations are unlikely to validate the "days". However we'd better specify a reasonable value. We learned that setting the "days" argument to a large number can cause unexpected results due to overflow. GCE team has decided to set this value as 10 years. BUG=b:62189155 TEST=None BRANCH=none Change-Id: If0375251b41e9584708355a6fd32192aa5ad0c1a Reviewed-on: https://chromium-review.googlesource.com/1088165 Commit-Ready: Edward Jee <edjee@google.com> Tested-by: Edward Jee <edjee@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org>
1 parent 2cc35b0 commit e21e46d

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

scripts/keygeneration/uefi/uefi_common.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ _make_self_signed_pair() {
7979
pushd "${key_name}" >/dev/null || return 1
8080
openssl req -new -x509 -nodes -newkey rsa:2048 -sha256 \
8181
-keyout "${key_name}.rsa" -out "${key_name}.pem" \
82-
-subj "${subj}" -days 73000
82+
-subj "${subj}" -days 3650
8383
popd >/dev/null
8484
}
8585

@@ -100,10 +100,10 @@ _make_child_pair() {
100100
pushd "${ca_name}/${ca_name}.children" >/dev/null || return 1
101101
openssl req -new -nodes -newkey rsa:2048 -sha256 \
102102
-keyout "${child_key_name}.rsa" -out "${child_key_name}.csr" \
103-
-subj "${subj}" -days 73000
103+
-subj "${subj}"
104104
openssl x509 -req -sha256 -CA "../${ca_name}.pem" -CAkey "../${ca_name}.rsa" \
105105
-CAcreateserial -in "${child_key_name}.csr" \
106-
-out "${child_key_name}.pem" -days 73000
106+
-out "${child_key_name}.pem" -days 3650
107107
popd >/dev/null
108108
}
109109

0 commit comments

Comments
 (0)