-
Notifications
You must be signed in to change notification settings - Fork 143
Store RADIUS Class per STA instead of EAPOL SM; preserve Class for ACL/MAC auth and accounting #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
venkatchimata
wants to merge
8
commits into
next
Choose a base branch
from
staging-WIFI-15318
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Store RADIUS Class per STA instead of EAPOL SM; preserve Class for ACL/MAC auth and accounting #1010
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
653ea84
rpcd: fix build failure against qca-wifi-7 iwinfo
blogic 68c3bd4
mediatek: fix eap111 network config and rebase WAP588M patch
blogic 5b64d78
ucentral-client: fix hostname validation
ArifAlam ac122c7
hostapd: add CUI to ACL RADIUS Access-Request
blogic 74261d1
hostapd: fix session-timeout with radius-psk
ArifAlam 1013cd9
hostapd: store RADIUS Class per STA instead of EAPOL SM;
f3086d4
ipq807x_v5.4 / hostapd: store RADIUS Class per STA instead of EAPOL SM;
7f99a4d
hostapd: store RADIUS Class per STA instead of
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
38 changes: 38 additions & 0 deletions
38
...wifi-6/hostapd/patches/t00-013-Allow-Session-Timeout-with-PSK-RADIUS-during-4-way-h.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| From e6ec62aa2d68e9436daeb4470260a101a06c9213 Mon Sep 17 00:00:00 2001 | ||
| From: Lee Harding <somerandomstring@gmail.com> | ||
| Date: Tue, 9 Apr 2024 15:06:38 -0700 | ||
| Subject: [PATCH] Allow Session-Timeout with PSK RADIUS during 4-way handshake | ||
|
|
||
| When the RADIUS response included a Session-Timeout attribute, but is | ||
| otherwise valid (an Access-Accept with a valid Tunnel-Password), the | ||
| association still failed due to the strict comparison of the accepted | ||
| value with HOSTAPD_ACL_ACCEPT. Apparently this combination wasn't | ||
| previously tested. | ||
|
|
||
| Extend this to allow a packet containing a valid Session-Timeout | ||
| attribute to be accepted by extending the "success" comparison to | ||
| include HOSTAPD_ACL_ACCEPT_TIMEOUT. | ||
|
|
||
| Fixes: 1c3438fec4ba ("RADIUS ACL/PSK check during 4-way handshake") | ||
| Signed-off-by: Lee Harding <somerandomstring@gmail.com> | ||
| --- | ||
| src/ap/ieee802_11_auth.c | 3 ++- | ||
| 1 file changed, 2 insertions(+), 1 deletion(-) | ||
|
|
||
| diff --git a/src/ap/ieee802_11_auth.c b/src/ap/ieee802_11_auth.c | ||
| index e723ae74b..98a877dec 100644 | ||
| --- a/src/ap/ieee802_11_auth.c | ||
| +++ b/src/ap/ieee802_11_auth.c | ||
| @@ -596,7 +596,8 @@ hostapd_acl_recv_radius(struct radius_msg *msg, struct radius_msg *req, | ||
|
|
||
| if (query->radius_psk) { | ||
| struct sta_info *sta; | ||
| - bool success = cache->accepted == HOSTAPD_ACL_ACCEPT; | ||
| + bool success = cache->accepted == HOSTAPD_ACL_ACCEPT || | ||
| + cache->accepted == HOSTAPD_ACL_ACCEPT_TIMEOUT; | ||
|
|
||
| sta = ap_get_sta(hapd, query->addr); | ||
| if (!sta || !sta->wpa_sm) { | ||
| -- | ||
| 2.52.0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --- a/src/ap/ieee802_11_auth.c | ||
| +++ b/src/ap/ieee802_11_auth.c | ||
| @@ -149,6 +149,14 @@ | ||
| if (add_common_radius_attr(hapd, hapd->conf->radius_auth_req_attr, | ||
| NULL, msg) < 0) | ||
| goto fail; | ||
| + | ||
| + if (hapd->conf->radius_request_cui && | ||
| + !radius_msg_add_attr(msg, | ||
| + RADIUS_ATTR_CHARGEABLE_USER_IDENTITY, | ||
| + (const u8 *) "\0", 1)) { | ||
| + wpa_printf(MSG_DEBUG, "Could not add CUI"); | ||
| + goto fail; | ||
| + } | ||
|
|
||
| os_snprintf(buf, sizeof(buf), RADIUS_802_1X_ADDR_FORMAT, | ||
| MAC2STR(addr)); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.