Fix: Allow download of script output with "shell" type in .txt format#416
Closed
TarunaChaudhary-RA wants to merge 1 commit into
Closed
Conversation
NavneetBarwal-RA
requested review from
carsten989
and removed request for
NavneetBarwal-RA
JIRA: https://telecominfraproject.atlassian.net/browse/WIFI-14937 Summary of changes: - This ensures the controller correctly processes files uploaded by APs when executing shell-type script commands, allowing successful download in `.txt` format. Signed-off-by: Taruna Chaudhary <taruna.chaudhary@routerarchitects.com>
TarunaChaudhary-RA
force-pushed
the
WIFI-14937-fix_script_command
branch
from
f619c5f to
331fddb
Compare
carsten989
requested changes
Aug 12, 2025
Contributor
carsten989
left a comment
carsten989
left a comment
There was a problem hiding this comment.
Please create a TIP branch and re-generate this PR based on that. We have problems with remote branches and our GITHUB actions.
is it possible to change the contenttype to be something less generic eg. text/scriptoutput so that we are not changing the behaviour for other existing responses?
Hi Carsten ,
|
Contributor
|
Closing this PR as per comments above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Allow download of script output with "shell" type in .txt format
JIRA: https://telecominfraproject.atlassian.net/browse/WIFI-14937
Summary of changes:
- This ensures the controller correctly processes files uploaded by APs when executing shell-type script commands, allowing successful download in
.txtformat.