Skip to content

Pki2 208 relaxed security settings allow rtty #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carsten989 merged 2 commits into from
Mar 31, 2026
Merged

Pki2 208 relaxed security settings allow rtty #435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddfa597
Allow RTTY to problematic devices in relaxed/none security mode
Mar 26, 2026
cd5e361
Merge remote-tracking branch 'origin/master' into PKI2-208-Relaxed-se…
Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion src/rttys/RTTYS_server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

#include "Poco/NObserver.h"
#include <Poco/Net/Context.h>
#include <Poco/Net/AcceptCertificateHandler.h>
#include "Poco/Net/SocketNotification.h"
#include "Poco/Net/NetException.h"
#include "Poco/Net/WebSocketImpl.h"
Expand Down Expand Up @@ -74,9 +75,32 @@ namespace OpenWifi {
const auto &Cas = MicroServiceConfigPath("ucentral.websocket.host.0.cas", "");
const auto &ClientCasFile = MicroServiceConfigPath("ucentral.websocket.host.0.clientcas", "");

// Read the security mode from websocket configuration
const auto &SecurityMode =
MicroServiceConfigGetString("ucentral.websocket.host.0.security", "relaxed");

// Parse security mode string to verification mode
Poco::Net::Context::VerificationMode VerificationLevel = Poco::Net::Context::VERIFY_RELAXED;
if (SecurityMode == "strict") {
VerificationLevel = Poco::Net::Context::VERIFY_STRICT;
} else if (SecurityMode == "none") {
VerificationLevel = Poco::Net::Context::VERIFY_NONE;
} else if (SecurityMode == "relaxed") {
VerificationLevel = Poco::Net::Context::VERIFY_RELAXED;
} else if (SecurityMode == "once") {
VerificationLevel = Poco::Net::Context::VERIFY_ONCE;
}

// Determine if we should accept all certificates (when security is "none")
bool acceptAllCerts = (VerificationLevel == Poco::Net::Context::VERIFY_NONE);

poco_information(Logger(),
fmt::format("RTTY device socket security mode: {} (acceptAllCerts: {})",
SecurityMode, acceptAllCerts));

Poco::Net::Context::Params P;

P.verificationMode = Poco::Net::Context::VERIFY_ONCE;
P.verificationMode = acceptAllCerts ? Poco::Net::Context::VERIFY_RELAXED : VerificationLevel;
P.verificationDepth = 9;
P.loadDefaultCAs = RootCas.empty();
P.cipherList = "ALL:!ADH:!LOW:!EXP:!MD5:@STRENGTH";
Expand Down Expand Up @@ -109,6 +133,13 @@ namespace OpenWifi {
DeviceSecureContext->disableProtocols(Poco::Net::Context::PROTO_TLSV1 |
Poco::Net::Context::PROTO_TLSV1_1);

// Accept all certificates when security mode is "none"
if (acceptAllCerts) {
DeviceSecureContext->setInvalidCertificateHandler(
Poco::SharedPtr<Poco::Net::InvalidCertificateHandler>(
new Poco::Net::AcceptCertificateHandler(true)));
}

SSL_CTX *SSLCtxDevice = DeviceSecureContext->sslContext();
SSL_CTX_dane_enable(SSLCtxDevice);
Poco::Net::IPAddress Addr(Poco::Net::IPAddress::wildcard(
Expand Down
Loading