Skip to content

Commit 69b7af7

Browse files
committed
fix-flaky-ssr-test: Last test
1 parent b490e66 commit 69b7af7

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

src/__acceptance_tests__/image-ssr-acceptance-test.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@ test('ssr image', async () => {
2929
return img?.style.opacity === '1';
3030
});
3131
console.log('image loaded?', result, Date.now());
32-
return result;
32+
if (!result) {
33+
throw new Error('Image not loaded yet');
34+
}
3335
});
3436
},
3537
});

src/image.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ export const ImageContent = React.forwardRef<HTMLImageElement, ImageProps>(
282282
<script
283283
// eslint-disable-next-line react/no-danger
284284
dangerouslySetInnerHTML={{
285-
__html: `console.log("Adding load image listener!"); document.getElementById("${imageId}").addEventListener('load', (e) => {e.target.style.opacity = "1"; console.log('inline script onLoad image event fired', Date.now());})`,
285+
__html: `console.log("Adding load image listener!, loaded", document.getElementById("${imageId}").complete); document.getElementById("${imageId}").addEventListener('load', (e) => {e.target.style.opacity = "1"; console.log('inline script onLoad image event fired', Date.now());})`,
286286
}}
287287
/>
288288
)}

0 commit comments

Comments
 (0)