Skip to content

Commit 7822d16

Browse files
authored
feat(skin)!: replace Movistar skin with Movistar-new (#1620)
Part of #626 — Major release plan 17.0.0. ## Changes - Replaces the `movistar-new` skin with `movistar`, removing the old `movistar` skin and promoting `movistar-new` as the canonical `movistar` skin. - Deletes `css/movistar-new.css`, `src/skins/movistar-new.tsx`, and the `movistar-new` logo files; the canonical `movistar` counterparts now carry the promoted content. - Removes the `Movistar-new` skin name, `MOVISTAR_NEW_SKIN`, `getMovistarNewSkin`, `movistarNewPalette`, and `MovistarNewLogo` from the public API and internal wiring. - Updates Storybook, Playroom, stories, screenshot tests, docs, and token tooling to reference the single `movistar` skin, and moves the `Movistar Sans` font mapping onto the canonical `movistar` skin. ## Note on the logo Unlike the O2 change (where the base and `-new` logos were identical), the Movistar logo was genuinely redesigned. The `movistar-new` logo content was therefore promoted into `logo-movistar.tsx` / `logo-movistar-shell.tsx` so the canonical skin ships the new artwork. ## Stack position This is **subtask 4 of 10** in the stacked PR chain. It targets the branch from #1597 and can only be merged after #1597 lands on `master`. See #626 for the full merge strategy and ordering. Closes #1617. --------- Co-authored-by: brtbrt <brtbrt@users.noreply.github.com>
1 parent 02c0036 commit 7822d16

130 files changed

Lines changed: 1476 additions & 3886 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/actions/audit-accessibility/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ const main = async () => {
250250
}
251251

252252
const stories = getStories().filter((story) => !STORIES_BLACKLIST.has(story));
253-
const skins = ['Movistar-new', 'O2', 'Vivo', 'Vivo-evolution', 'Blau'];
253+
const skins = ['Movistar', 'O2', 'Vivo', 'Vivo-evolution', 'Blau'];
254254

255255
/**
256256
* @type Array<[story: string, skin: string]>

.storybook/colors.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import {palette as cyberPalette} from '../src/community/skins/cyber-skin';
22

33
export const AVAILABLE_SKINS = [
4-
'Movistar-new',
54
'Movistar',
65
'O2',
76
'Vivo',
@@ -22,13 +21,6 @@ type SkinTheme = {primary: string; textPrimary: string; textPrimaryInverse: stri
2221
export const getColors = (skin: Skin): SkinTheme => {
2322
switch (skin) {
2423
case 'Movistar':
25-
return {
26-
primary: '#019DF4',
27-
textPrimary: '#0B2739',
28-
textPrimaryInverse: '#FFFFFF',
29-
textSecondary: '#6B6C6F',
30-
};
31-
case 'Movistar-new':
3224
return {
3325
primary: '#0066FF',
3426
textPrimary: '#262423',

.storybook/preview.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import * as React from 'react';
99
import {
1010
ThemeContextProvider,
1111
MOVISTAR_SKIN,
12-
MOVISTAR_NEW_SKIN,
1312
VIVO_SKIN,
1413
VIVO_EVOLUTION_SKIN,
1514
O2_SKIN,
@@ -33,7 +32,6 @@ const getSkin = (searchParams: URLSearchParams) => {
3332
const qsSkin = searchParams.get('skin');
3433
return [
3534
MOVISTAR_SKIN,
36-
MOVISTAR_NEW_SKIN,
3735
O2_SKIN,
3836
VIVO_SKIN,
3937
VIVO_EVOLUTION_SKIN,
@@ -133,10 +131,10 @@ const MisticaThemeProvider = ({
133131
<style>{`body {font-family: "Vivo Type"}`}</style>
134132
)}
135133
{skin === TELEFONICA_SKIN && <style>{`body {font-family: "Telefonica Sans"}`}</style>}
136-
{(skin === MOVISTAR_SKIN || skin === O2_SKIN || skin === ESIMFLAG_SKIN) && (
134+
{(skin === O2_SKIN || skin === ESIMFLAG_SKIN) && (
137135
<style>{`body {font-family: "On Air"}`}</style>
138136
)}
139-
{skin === MOVISTAR_NEW_SKIN && <style>{`body {font-family: "Movistar Sans"}`}</style>}
137+
{skin === MOVISTAR_SKIN && <style>{`body {font-family: "Movistar Sans"}`}</style>}
140138
<Story {...context} />
141139
</OverscrollColorProvider>
142140
</ThemeContextProvider>

.storybook/theme-selector-addon/manager.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const renderPrimaryColorDot = (skinName: Skin) => (
2323

2424
const ThemeSelectorAddon = ({api}: {api: API}) => {
2525
const [currentSkin, setCurrentSkin] = React.useState<Skin>(
26-
() => (api.getQueryParam('skin') as Skin) || 'Movistar-new'
26+
() => (api.getQueryParam('skin') as Skin) || 'Movistar'
2727
);
2828

2929
React.useEffect(() => {

.storybook/themes.tsx

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import {
22
getMovistarSkin,
3-
getMovistarNewSkin,
43
getO2Skin,
54
getVivoSkin,
65
getVivoEvolutionSkin,
@@ -15,11 +14,6 @@ export const Movistar = {
1514
skin: getMovistarSkin(),
1615
} as const;
1716

18-
export const Movistar_New = {
19-
i18n: {locale: 'es-ES', phoneNumberFormattingRegionCode: 'ES'},
20-
skin: getMovistarNewSkin(),
21-
} as const;
22-
2317
export const O2 = {
2418
i18n: {locale: 'en-GB', phoneNumberFormattingRegionCode: 'GB'},
2519
skin: getO2Skin(),
@@ -55,14 +49,4 @@ export const Cyber = {
5549
skin: getCyberSkin(),
5650
} as const;
5751

58-
export const AVAILABLE_THEMES = [
59-
Movistar,
60-
Movistar_New,
61-
O2,
62-
Vivo,
63-
Vivo_Evolution,
64-
Telefonica,
65-
Blau,
66-
Esimflag,
67-
Cyber,
68-
];
52+
export const AVAILABLE_THEMES = [Movistar, O2, Vivo, Vivo_Evolution, Telefonica, Blau, Esimflag, Cyber];

css/movistar-new.css

Lines changed: 0 additions & 1474 deletions
This file was deleted.

css/movistar.css

Lines changed: 883 additions & 884 deletions
Large diffs are not rendered by default.

doc/fonts.md

Lines changed: 11 additions & 12 deletions

doc/llms/llms.md

Lines changed: 13 additions & 13 deletions

doc/patterns.md

Lines changed: 2 additions & 2 deletions

0 commit comments

Comments
 (0)