Current implementation
The ThemeContextProvider accepts to configure the dimensions of the NavigationBar:
dimensions: {
headerMobileHeight: number;
headerDesktopHeight: number;
};
But these dimensions are not being used by the NavigationBar component
There is a context named FixedToTop that allows to set the height of the elements that are being placed to the top (like a NavigationBar) but the NavigationBar component isn't using it, instead, as we see in the "default-page-layout" in webapp, this is manually used:
https://github.com/Telefonica/webapp/blob/master/web/src/common/components/default-page-layout.tsx#L51
Possible improvements
- The
NavigationBar component should set its height according to the dimensions value from the theme
- The
NavigationBar component should set the FixedToTop context value
Current implementation
The ThemeContextProvider accepts to configure the dimensions of the
NavigationBar:But these dimensions are not being used by the
NavigationBarcomponentThere is a context named
FixedToTopthat allows to set the height of the elements that are being placed to the top (like aNavigationBar) but theNavigationBarcomponent isn't using it, instead, as we see in the "default-page-layout" in webapp, this is manually used:https://github.com/Telefonica/webapp/blob/master/web/src/common/components/default-page-layout.tsx#L51
Possible improvements
NavigationBarcomponent should set its height according to thedimensionsvalue from the themeNavigationBarcomponent should set theFixedToTopcontext value