Skip to content

feat(HighlightedValueBlock): new pretitle and strickedValue props #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atabel merged 5 commits into from
Apr 4, 2025
Merged

feat(HighlightedValueBlock): new pretitle and strickedValue props #1329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ac3d97
feat: updated HighlightedValueBlock added pretitel and striked value
wendellguimaraes-tlf Mar 14, 2025
2e4d9fe
Merge branch 'master' of github.com:Telefonica/mistica-web into highl…
wendellguimaraes-tlf Mar 14, 2025
1de323d
fix: adjusted order BlockHighlightedValue args and removed capitalize…
wendellguimaraes-tlf Mar 21, 2025
56a4160
fix: updated snapshot
wendellguimaraes-tlf Mar 21, 2025
f3e7d34
fix: keeped strikedValue just as a string
wendellguimaraes-tlf Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...napshots__/blocks-screenshot-test-tsx-blocks-highlighted-value-block-1-snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 9 additions & 1 deletion src/community/__stories__/blocks-story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,10 @@ type HighlightedValueBlockArgs = {

secondaryValue: string;

pretitle: string;
title: string;
description: string;
strikedValue: string;
};

export const BlockHighlightedValue: StoryComponent<HighlightedValueBlockArgs> = ({
Expand All @@ -143,16 +145,20 @@ export const BlockHighlightedValue: StoryComponent<HighlightedValueBlockArgs> =
value,
text,
secondaryValue,
pretitle,
title,
description,
strikedValue,
}) => {
return (
<ResponsiveLayout>
<Box paddingY={24} dataAttributes={{testid: 'highlighted-value-block'}}>
<HighlightedValueBlock
headline={<Tag type={headlineType}>{headline}</Tag>}
pretitle={pretitle}
title={title}
description={description}
strikedValue={strikedValue}
headings={[
{value, text},
{value: secondaryValue, valueColor: vars.colors.textSecondary},
Expand All @@ -167,8 +173,10 @@ BlockHighlightedValue.storyName = 'HighlightedValueBlock';
BlockHighlightedValue.args = {
headline: 'Priority',
headlineType: 'promo',
text: 'text',
pretitle: 'Pretitle',
strikedValue: 'striked Value',
value: '20',
text: 'text',
secondaryValue: '20',
title: 'title',
description: 'description',
Expand Down
13 changes: 12 additions & 1 deletion src/community/blocks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,21 +160,32 @@ interface HighlightedValueBlockProps {
headline?: RendersNullableElement<typeof Tag>;
headings?: ReadonlyArray<Heading>;
title?: string;
pretitle?: string;
description?: ReadonlyArray<string> | string;
strikedValue?: string;
'aria-label'?: string;
}

export const HighlightedValueBlock = ({
headline,
headings,
title,
pretitle,
description,
strikedValue,
'aria-label': ariaLabel,
}: HighlightedValueBlockProps): JSX.Element => {
return (
<div aria-label={ariaLabel}>
{headline && <Box paddingBottom={24}>{headline}</Box>}

<Stack space={2}>
{pretitle && <Text2 regular>{pretitle}</Text2>}
{strikedValue && (
<Text2 regular color={vars.colors.textSecondary} decoration="line-through">
{strikedValue}
</Text2>
)}
</Stack>
{headings && (
<Stack space={2}>
{headings.map((heading, index) => (
Expand Down
Loading