fixed footerlayout#1333
Closed
SilasYaw wants to merge 4 commits into
Closed
Conversation
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 3c46c5e. |
This commit implements the necessary changes to dynamically handle `scroll-padding-bottom` on the `html` element. This ensures that the fixed footer does not block the focus of overflow elements when visible. Changes: - Added a `<style>` tag to dynamically set `scroll-padding-bottom` on the `html` element based on the footer height. - Ensured that the fixed footer height is calculated and applied declaratively. - Updated the `FixedFooterLayout` component to handle this behavior consistently across devices.
|
Screenshot tests report ✔️ All passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: dynamically handle scroll-padding-bottom for fixed footer
This PR implements the necessary changes to dynamically handle scroll-padding-bottom on the html, this ensures that the fixed footer does not block the focus of overflow element when visible.
Related: This commit is related to O2DE-6995.