fix(FixedFooterLayout): obscured focus#1334
Merged
Merged
Conversation
This commit implements the necessary changes to dynamically handle `scroll-padding-bottom` on the `html` element. This ensures that the fixed footer does not block the focus of overflow elements when visible. Changes: - Added a `<style>` tag to dynamically set `scroll-padding-bottom` on the `html` element based on the footer height. - Ensured that the fixed footer height is calculated and applied declaratively. - Updated the `FixedFooterLayout` component to handle this behavior consistently across devices.
This commit implements the necessary changes to dynamically handle scroll-padding-bottom on the html element. This ensures that the fixed footer does not block the focus of overflow elements when visible. Added a <style> tag to dynamically set scroll-padding-bottom on the html element based on the footer height. Related: This commit is related to [O2DE-6995](https://jira.tid.es/browse/O2DE-6995).
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
claramunt
changed the title
SilasYaw
changed the title
SilasYaw
changed the title
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 2605de2. |
claramunt
changed the title
atabel
reviewed
Mar 27, 2025
claramunt
approved these changes
Mar 27, 2025
Added condition to included the visibility of the footer Refactor condition to ensure style is applied only when the footer is visible and editable
… Refactor condition to ensure style is applied, removed ; only when the footer is visible and editable
|
Screenshot tests report ✔️ All passing |
atabel
approved these changes
Mar 27, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
tuentisre
pushed a commit
that referenced
this pull request
Mar 27, 2025
## [16.18.2](v16.18.1...v16.18.2) (2025-03-27) ### Bug Fixes * **FixedFooterLayout:** obscured focus ([#1334](#1334)) ([1a89176](1a89176)), closes [/#diff-a20f24af3140080300870a68a5accb89feee523f1c59592a9e57d0f2bf4d02baR166](https://github.com///issues/diff-a20f24af3140080300870a68a5accb89feee523f1c59592a9e57d0f2bf4d02baR166)
Collaborator
|
🎉 This PR is included in version 16.18.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(FixedFooterLayout): fixed footer layout obscured focus
This pull request includes a small change to the
FixedFooterLayoutcomponent insrc/fixed-footer-layout.tsx. The change ensures that when the footer is visible, a style is applied to set thescroll-padding-bottomto the height of the footer.src/fixed-footer-layout.tsx: Added a style element to setscroll-padding-bottomwhen the footer is visible.This commit is related to [O2DE-6995].