Skip to content

feat(mistica-css): breadcrumbs#1349

Merged
atabel merged 11 commits into
masterfrom
WEB-2176
May 6, 2025
Merged

feat(mistica-css): breadcrumbs#1349
atabel merged 11 commits into
masterfrom
WEB-2176

Conversation

@DavidNietoGonzalez
Copy link
Copy Markdown
Contributor

@DavidNietoGonzalez DavidNietoGonzalez changed the title CSS breadcrumbs feat(breacrumbs): CSS breadcrumbs Apr 21, 2025
@DavidNietoGonzalez DavidNietoGonzalez changed the title feat(breacrumbs): CSS breadcrumbs feat(mistica-css): breadcrumbs Apr 21, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2025

Size stats

master this branch diff
Total JS 12.4 MB 12.4 MB 0 B
JS without icons 2.12 MB 2.12 MB 0 B
Lib overhead 77.3 kB 77.3 kB 0 B
Lib overhead (gzip) 17.6 kB 17.6 kB 0 B

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2025

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2025

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-ap2z46e9s-flows-projects-65bb050e.vercel.app

Built with commit e5246cc.
This pull request is being automatically deployed with vercel-action

Comment thread css/mistica-common.css
Comment thread css/mistica-common.css Outdated
Comment thread css/mistica-common.css
Comment thread examples/css/index.html Outdated
<a href="/" class="mistica-breadcrumb-text">
Home
</a>
<span class="mistica-breadcrumb-separator">/</span>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could avoid this span by adding the / with an :after pseudoelement

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed and added the pseudo element

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAI ARIA recommends to avoid including the element as content since the screen reader will stop at it and read it.

Screenshot 2025-05-05 at 12 37 24

This is how they solve this problem

using a display technique that is not represented in the accessibility tree used by screen readers prevents redundant and potentially distracting verbosity

Extracted from: https://www.w3.org/WAI/ARIA/apg/patterns/breadcrumb/examples/breadcrumb/

Would be also ideal to change React implementation to follow this? @atabel

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in react implementation we use separated divs for /, so we could just add aria-hidden there

Comment thread examples/css/index.html Outdated
Comment thread examples/css/index.html Outdated
Comment thread css/mistica-common.css Outdated
Comment thread css/mistica-common.css Outdated
Comment thread css/mistica-common.css Outdated
Comment thread css/mistica-common.css Outdated
@atabel atabel requested review from aweell and yceballost April 24, 2025 07:15
Comment thread examples/css/index.html
Comment thread css/mistica-common.css Outdated
line-height: var(--mistica-line-height-1);
font-weight: var(--mistica-font-weight-1);
color: var(--vcolor-textPrimary);
margin: 0 3px;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there aren't uniform spacing between elements

This fix this visual

Suggested change
margin: 0 3px;
margin-right: 3px;

before/after
image
image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@atabel atabel requested a review from yceballost April 29, 2025 12:59
Copy link
Copy Markdown
Contributor

@yceballost yceballost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

Copy link
Copy Markdown
Contributor

@aweell aweell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component reflow behaviour seems odd

css:
Screenshot 2025-05-05 at 12 46 07

react:
Screenshot 2025-05-05 at 12 47 03

@DavidNietoGonzalez
Copy link
Copy Markdown
Contributor Author

Change to avoid the unwrapped content on responsive.

@atabel atabel added this pull request to the merge queue May 6, 2025
Merged via the queue into master with commit eeb36b2 May 6, 2025
11 checks passed
@atabel atabel deleted the WEB-2176 branch May 6, 2025 11:16
tuentisre pushed a commit that referenced this pull request May 6, 2025
# [16.23.0](v16.22.0...v16.23.0) (2025-05-06)

### Features

* **mistica-css:** breadcrumbs ([#1349](#1349)) ([eeb36b2](eeb36b2))
* **mistica-css:** card asset ([#1351](#1351)) ([45c275f](45c275f))
* **mistica-css:** GridLayout ([#1355](#1355)) ([da0a953](da0a953))
* **mistica-css:** Table implementation ([#1352](#1352)) ([d26129e](d26129e))
* **PinField:** wrap to next line when digits don't fit in viewport ([#1359](#1359)) ([13e13ed](13e13ed))
* **TextField:** make field error aria-live ([#1348](#1348)) ([1c45c55](1c45c55))
@tuentisre
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 16.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants