Skip to content

feat(mistica-css): breadcrumbs #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atabel merged 11 commits into from
May 6, 2025
Merged

feat(mistica-css): breadcrumbs #1349

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
66bd7f6
CSS breadcrumbs
davidvdshop Apr 21, 2025
e6aca66
fix missing character
davidvdshop Apr 21, 2025
71c74ad
WEB-2176 change class name, remove elements
davidvdshop Apr 22, 2025
1ebe98c
resolve merge
davidvdshop Apr 23, 2025
5b630d5
Fix wrong indent
davidvdshop Apr 23, 2025
a9da94b
missing spaces
davidvdshop Apr 23, 2025
f56e422
change selector to reduce css
davidvdshop Apr 24, 2025
a617e87
Changes on text decoration
davidvdshop Apr 28, 2025
fa6aa4a
Refactor css to break word on long links
davidvdshop May 5, 2025
d10b64d
change slash render
davidvdshop May 6, 2025
e5246cc
resolve merge
davidvdshop May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions css/mistica-common.css
View file
Open in desktop
Comment thread
atabel marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,37 @@
color: var(--vcolor-tagTextError);
}

/* Breadcrumbs */
.mistica-breadcrumb-list {
display: flex;
flex: 1;
align-items: flex-end;
padding: 0;
margin: 0;
list-style: none;

Comment thread
atabel marked this conversation as resolved.
}

[class^='mistica-breadcrumb-'] {
Comment thread
atabel marked this conversation as resolved.
Outdated
text-decoration: none;
font-size: var(--mistica-font-size-1);
line-height: var(--mistica-line-height-1);
font-weight: var(--mistica-font-weight-1);
color: var(--vcolor-textPrimary);
}

.mistica-breadcrumb-separator {
padding-right: 3px;
}

.mistica-breadcrumb-text:hover {
text-decoration: underline;
}

.mistica-breadcrumb-text-current {
color: var(--vcolor-textSecondary);
}

/* Buttons */
[class^='mistica-button'] {
--button-font-size: var(--mistica-font-size-3);
Expand Down
25 changes: 25 additions & 0 deletions examples/css/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,31 @@ <h3 class="mistica-text-title2">Tag</h3>
<div class="mistica-tag-error">Error</div>
</div>

<h3 class="mistica-text-title2">Breadcrumbs</h3>
<div class="cards-group">
<nav>
<ol class="mistica-breadcrumb-list">
Comment thread
atabel marked this conversation as resolved.
Outdated
<li class="mistica-breadcrumb-list-item">
<a href="/" class="mistica-breadcrumb-text">
Home
</a>
<span class="mistica-breadcrumb-separator">/</span>
Copy link
Copy Markdown
Contributor

@atabel atabel Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could avoid this span by adding the / with an :after pseudoelement

Copy link
Copy Markdown
Contributor Author

@DavidNietoGonzalez DavidNietoGonzalez Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed and added the pseudo element

Copy link
Copy Markdown
Contributor

@aweell aweell May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAI ARIA recommends to avoid including the element as content since the screen reader will stop at it and read it.

Screenshot 2025-05-05 at 12 37 24

This is how they solve this problem

using a display technique that is not represented in the accessibility tree used by screen readers prevents redundant and potentially distracting verbosity

Extracted from: https://www.w3.org/WAI/ARIA/apg/patterns/breadcrumb/examples/breadcrumb/

Would be also ideal to change React implementation to follow this? @atabel

Copy link
Copy Markdown
Contributor

@atabel atabel May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in react implementation we use separated divs for /, so we could just add aria-hidden there

</li>
<li class="mistica-breadcrumb-list-item">
<a href="/" class="mistica-breadcrumb-text">
Section
</a>
<span class="mistica-breadcrumb-separator">/</span>
</li>
<li class="mistica-breadcrumb-list-item">
<span class="mistica-breadcrumb-text-current">
Subsection
</span>
Comment thread
atabel marked this conversation as resolved.
Outdated
</li>
</ol>
</nav>
</div>

<h3 class="mistica-text-title2">Buttons</h3>
<div>
<a class="mistica-button-primary" href="#">Primary</a>
Expand Down