Skip to content

feat(mistica-css): Chip#1350

Merged
atabel merged 1 commit into
masterfrom
atoledano-mistica-chip-css
Apr 28, 2025
Merged

feat(mistica-css): Chip#1350
atabel merged 1 commit into
masterfrom
atoledano-mistica-chip-css

Conversation

@atabel

@atabel atabel commented Apr 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Apr 21, 2025

Copy link
Copy Markdown

Size stats

master this branch diff
Total JS 12.4 MB 12.4 MB 0 B
JS without icons 2.12 MB 2.12 MB 0 B
Lib overhead 77.3 kB 77.3 kB 0 B
Lib overhead (gzip) 17.5 kB 17.5 kB 0 B

atabel
atabel commented Apr 21, 2025
View reviewed changes
Comment thread examples/css/index.html
<div>
<button class="mistica-chip">Chip button</button>
<a href="#" class="mistica-chip">Chip a</a>
<label class="mistica-chip"><input type="checkbox" /><span>Chip checkbox</span></label>

@atabel atabel Apr 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the span for the label text is needed in this case to be able to change the label styles depending on the sibling checkbox state (:active :checked, etc) input:checked + span

I could avoid the span using :has() to style the label with something like label:has(input:checked), but has() doesn't have enough browser support

@github-actions

github-actions Bot commented Apr 21, 2025

Copy link
Copy Markdown

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@github-actions

github-actions Bot commented Apr 21, 2025

Copy link
Copy Markdown

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-3h5amac4f-flows-projects-65bb050e.vercel.app

Built with commit 595479e.
This pull request is being automatically deployed with vercel-action

@atabel atabel added this pull request to the merge queue Apr 28, 2025
Merged via the queue into master with commit ca4aa01 Apr 28, 2025
@atabel atabel deleted the atoledano-mistica-chip-css branch April 28, 2025 09:57
tuentisre pushed a commit that referenced this pull request Apr 29, 2025
@semantic-release-bot
chore(release): 16.22.0 [skip ci]
96044d0 
# [16.22.0](v16.21.0...v16.22.0) (2025-04-29)

### Features

* **mistica-css:** Chip ([#1350](#1350)) ([ca4aa01](ca4aa01))
* **sheet-root:** disable focus trap when running in an iframe ([#1353](#1353)) ([#1354](#1354)) ([19aeaf1](19aeaf1))
@tuentisre

tuentisre commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 16.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yceballost yceballost yceballost approved these changes
@aweell aweell aweell approved these changes
+1 more reviewer
@DavidNietoGonzalez DavidNietoGonzalez DavidNietoGonzalez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@atabel @tuentisre @yceballost @aweell @DavidNietoGonzalez