Conversation
atabel
reviewed
May 12, 2025
Comment on lines
+963
to
+965
| .mistica-vertical-spacing-0 { | ||
| gap: 0; | ||
| } |
Contributor
There was a problem hiding this comment.
I'd call these classes .mistica-grid-vertical-space-0 and use row-gap instead of gap
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 1a8c794. |
atabel
reviewed
May 12, 2025
| } | ||
| } | ||
|
|
||
| .mistica-col-1 { |
Contributor
There was a problem hiding this comment.
as talked in today meeting, rename these classes to .mistica-grid-col-1
| /* Grid Layout */ | ||
|
|
||
| .mistica-grid-layout { | ||
| display: grid; |
Contributor
There was a problem hiding this comment.
please review prettier formatting
atabel
approved these changes
May 13, 2025
tuentisre
pushed a commit
that referenced
this pull request
May 13, 2025
# [16.25.0](v16.24.0...v16.25.0) (2025-05-13) ### Bug Fixes * **TextField:** make prefix hidden to screen readers ([#1362](#1362)) ([9644cd5](9644cd5)) ### Features * **mistica-css:** checkbox ([#1367](#1367)) ([eb9d5b8](eb9d5b8)) * **mistica-css:** grid-layout ([#1365](#1365)) ([717b0ce](717b0ce)) * **Slideshow:** allow images with border radius inside ([#1363](#1363)) ([46b1138](46b1138)) * **TextX:** add testid ([#1361](#1361)) ([1452f71](1452f71))
Collaborator
|
🎉 This PR is included in version 16.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WEB-2192
Added classes to avoid js on AEM part.