Skip to content

feat(mistica-css): grid-layout#1365

Merged
atabel merged 12 commits into
masterfrom
WEB-2192
May 13, 2025
Merged

feat(mistica-css): grid-layout#1365
atabel merged 12 commits into
masterfrom
WEB-2192

Conversation

@DavidNietoGonzalez
Copy link
Copy Markdown
Contributor

WEB-2192
Added classes to avoid js on AEM part.

@DavidNietoGonzalez DavidNietoGonzalez requested a review from atabel May 9, 2025 08:30
Comment thread css/mistica-common.css Outdated
Comment on lines +963 to +965
.mistica-vertical-spacing-0 {
gap: 0;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call these classes .mistica-grid-vertical-space-0 and use row-gap instead of gap

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done¡

@DavidNietoGonzalez DavidNietoGonzalez requested a review from atabel May 12, 2025 08:24
@github-actions
Copy link
Copy Markdown

Size stats

master this branch diff
Total JS 12.4 MB 12.4 MB 0 B
JS without icons 2.12 MB 2.12 MB 0 B
Lib overhead 77.6 kB 77.6 kB 0 B
Lib overhead (gzip) 17.6 kB 17.6 kB 0 B

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2025

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2025

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-put4u5ngs-flows-projects-65bb050e.vercel.app

Built with commit 1a8c794.
This pull request is being automatically deployed with vercel-action

Comment thread css/mistica-common.css Outdated
}
}

.mistica-col-1 {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as talked in today meeting, rename these classes to .mistica-grid-col-1

Comment thread css/mistica-common.css
/* Grid Layout */

.mistica-grid-layout {
display: grid;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review prettier formatting

@DavidNietoGonzalez DavidNietoGonzalez requested a review from atabel May 13, 2025 07:09
@atabel atabel added this pull request to the merge queue May 13, 2025
Merged via the queue into master with commit 717b0ce May 13, 2025
11 checks passed
@atabel atabel deleted the WEB-2192 branch May 13, 2025 09:49
tuentisre pushed a commit that referenced this pull request May 13, 2025
# [16.25.0](v16.24.0...v16.25.0) (2025-05-13)

### Bug Fixes

* **TextField:** make prefix hidden to screen readers ([#1362](#1362)) ([9644cd5](9644cd5))

### Features

* **mistica-css:** checkbox ([#1367](#1367)) ([eb9d5b8](eb9d5b8))
* **mistica-css:** grid-layout ([#1365](#1365)) ([717b0ce](717b0ce))
* **Slideshow:** allow images with border radius inside ([#1363](#1363)) ([46b1138](46b1138))
* **TextX:** add testid ([#1361](#1361)) ([1452f71](1452f71))
@tuentisre
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 16.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants