Skip to content

feat(mistica-css): TextField / SearchField#1370

Merged
atabel merged 6 commits into
masterfrom
atoledano-css-text-fields
May 20, 2025
Merged

feat(mistica-css): TextField / SearchField#1370
atabel merged 6 commits into
masterfrom
atoledano-css-text-fields

Conversation

@atabel
Copy link
Copy Markdown
Contributor

@atabel atabel commented May 13, 2025

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2025

Size stats

master this branch diff
Total JS 12.4 MB 12.4 MB 0 B
JS without icons 2.12 MB 2.12 MB 0 B
Lib overhead 77.6 kB 77.6 kB 0 B
Lib overhead (gzip) 17.6 kB 17.6 kB 0 B

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2025 •
edited
Loading

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

atabel
atabel commented May 13, 2025
View reviewed changes
Comment thread examples/css/index.html
<h4 class="mistica-text-title1">TextField</h4>
<div class="vertical-group">
<div class="mistica-text-field">
<input id="text-field-1" type="text" placeholder=" " />
Copy link
Copy Markdown
Contributor Author

@atabel atabel May 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that placeholder is always needed. Without a placeholder we can't implement the shrinking label effect when the input is filled (without js). With placeholder we can use the :placeholder-visible pseudoclass to do the trick. When we don't want the input to have a visible placeholder, we can set it to " " as I'm doing in this example

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2025 •
edited
Loading

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-hywlmevyc-flows-projects-65bb050e.vercel.app

Built with commit 882ae54.
This pull request is being automatically deployed with vercel-action

yceballost
yceballost requested changes May 13, 2025
View reviewed changes
Comment thread examples/css/index.html
Comment thread examples/css/index.html Outdated
atabel and others added 2 commits May 14, 2025 12:25
@atabel @yceballost
Update examples/css/index.html
beac255 
Co-authored-by: Ignacio Ceballos (Yayo) <yceballost@gmail.com>
@atabel
fix label ellipsis
cef1e08
@atabel atabel requested a review from yceballost May 14, 2025 11:53
@atabel atabel added this pull request to the merge queue May 20, 2025
Merged via the queue into master with commit 55781c4 May 20, 2025
11 checks passed
@atabel atabel deleted the atoledano-css-text-fields branch May 20, 2025 11:10
tuentisre pushed a commit that referenced this pull request May 28, 2025
@semantic-release-bot
chore(release): 16.26.0 [skip ci]
52c7882 
# [16.26.0](v16.25.0...v16.26.0) (2025-05-28)

### Features

* **mistica-css:** counter ([#1372](#1372)) ([70d8beb](70d8beb))
* **mistica-css:** ErrorFeedbackScreen ([#1371](#1371)) ([99ea3cf](99ea3cf))
* **mistica-css:** slider ([#1374](#1374)) ([89c6aee](89c6aee))
* **mistica-css:** switch ([#1364](#1364)) ([7b6df80](7b6df80))
* **mistica-css:** TextField / SearchField ([#1370](#1370)) ([55781c4](55781c4))
* **RowList, BoxedRowList, Stack:** O2DE-7699 RowList with aria-live and aria-atomic attributes ([#1376](#1376)) ([5070c61](5070c61))
@tuentisre
Copy link
Copy Markdown
Collaborator

tuentisre commented May 28, 2025

🎉 This PR is included in version 16.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yceballost yceballost yceballost approved these changes

+1 more reviewer

@DavidNietoGonzalez DavidNietoGonzalez DavidNietoGonzalez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atabel @tuentisre @yceballost @DavidNietoGonzalez