Skip to content

chore(PreviewTools): Include border prop#1482

Merged
Marcosld merged 18 commits into
masterfrom
iceballos-previewTools-border
Mar 19, 2026
Merged

chore(PreviewTools): Include border prop#1482
Marcosld merged 18 commits into
masterfrom
iceballos-previewTools-border

Conversation

@yceballost
Copy link
Copy Markdown
Contributor

New version of Playroom include a border with embed previews. This cause an extra border in the current visualizations like:
image

We are going to manage this border from PreviewTools because also need to present examples without border like:
image

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 20, 2026

Size stats

master this branch diff
Total JS 16.1 MB 16.1 MB -8 B
JS without icons 2.01 MB 2.01 MB -8 B
Lib overhead 92.5 kB 92.5 kB 0 B
Lib overhead (gzip) 19.9 kB 19.9 kB 0 B

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 20, 2026

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-rnb512415-flows-projects-65bb050e.vercel.app

Built with commit 58e391c.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 20, 2026

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@yceballost yceballost requested a review from atabel January 20, 2026 17:18
Comment thread playroom/components/index.tsx Outdated
Comment thread playroom/components/index.tsx Outdated
@Marcosld Marcosld self-requested a review March 3, 2026 10:48
Marcosld
Marcosld previously approved these changes Mar 3, 2026
Comment thread .yarn/patches/playroom-npm-1.0.3-d8e0669615.patch Outdated
@yceballost yceballost requested a review from Marcosld March 3, 2026 12:17
@Marcosld
Copy link
Copy Markdown
Contributor

Marcosld commented Mar 4, 2026

LGTM!

On the other hand... It looks like guys at playroom already merged our PR to fix opening playroom over LAN: https://github.com/seek-oss/playroom/releases/tag/v1.0.7. If we upgrade playroom we should be able to remove my patch...

This leads me to... have you tried hiding the border with regular CSS overriding without patching the playroom package? I think we should avoid patching if we can because patching is kinda hard to maintain in the long term.

@yceballost
Copy link
Copy Markdown
Contributor Author

LGTM!

On the other hand... It looks like guys at playroom already merged our PR to fix opening playroom over LAN: seek-oss/playroom@v1.0.7 (release). If we upgrade playroom we should be able to remove my patch...

This leads me to... have you tried hiding the border with regular CSS overriding without patching the playroom package? I think we should avoid patching if we can because patching is kinda hard to maintain in the long term.

#1511

@Marcosld Marcosld enabled auto-merge March 19, 2026 15:43
@Marcosld Marcosld added this pull request to the merge queue Mar 19, 2026
Merged via the queue into master with commit a557abb Mar 19, 2026
11 checks passed
@Marcosld Marcosld deleted the iceballos-previewTools-border branch March 19, 2026 16:19
@tuentisre
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 16.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants