Skip to content

feat(FileUpload): new component#1489

Merged
atabel merged 28 commits into
masterfrom
atoledano-file-upload
Mar 5, 2026
Merged

feat(FileUpload): new component#1489
atabel merged 28 commits into
masterfrom
atoledano-file-upload

Conversation

@atabel
Copy link
Copy Markdown
Contributor

@atabel atabel commented Feb 2, 2026 •
edited
Loading

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2026 •
edited
Loading

Size stats

master this branch diff
Total JS 16.1 MB 16.1 MB +24.6 kB
JS without icons 1.98 MB 2 MB +24.5 kB
Lib overhead 91.4 kB 92.2 kB +797 B
Lib overhead (gzip) 19.8 kB 19.9 kB +98 B

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2026 •
edited
Loading

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-iuulq4bj0-flows-projects-65bb050e.vercel.app

Built with commit fbb44f7.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2026 •
edited
Loading

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@atabel atabel marked this pull request as ready for review February 16, 2026 17:07
@yceballost yceballost requested a review from aweell February 17, 2026 12:48
yceballost
yceballost requested changes Feb 17, 2026
View reviewed changes
Comment thread src/__stories__/file-upload-story.tsx Outdated
Comment thread src/file-upload.tsx Outdated
Comment thread src/__stories__/file-upload-story.tsx Outdated
Comment thread src/file-upload.tsx Outdated
Comment thread src/file-upload.css.ts Outdated
Comment thread src/file-upload.css.ts Outdated
Comment thread src/file-upload.css.ts Outdated
Comment thread src/file-upload.css.ts Outdated
Comment thread src/__stories__/file-upload-story.tsx
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 18, 2026 •
edited
Loading

Screenshot tests report

✔️ All passing

Marcosld
Marcosld previously approved these changes Feb 18, 2026
View reviewed changes
Comment thread src/file-upload.tsx
@aweell
Copy link
Copy Markdown
Contributor

aweell commented Feb 18, 2026 •
edited
Loading

The dropzone keyboard/reader focus should wrap the entire dropzone area

https://www.figma.com/design/e8d3PkXitUJ1Jwgc9Y3mNc/%F0%9F%94%B8-Input-Fields---Forms-Specs?node-id=6233-4385&t=VEsWbmV7olQ98clc-4

(Super corner case) Testing this on iOS seems to be issues with the touch, sometimes when I touch the button and then the dropzone, the fist press in the dropzone doesn't work

yceballost
yceballost previously approved these changes Feb 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@yceballost yceballost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 😍

yceballost pushed a commit that referenced this pull request Feb 28, 2026
@semantic-release-bot
chore(release): 16.52.0 [skip ci]
31ab591 
# [16.52.0](v16.51.0...v16.52.0) (2026-02-27)

### Bug Fixes

* **Card:** VoiceOver rectangle doesn't cover the whole card when using href/to ([#1501](#1501)) ([025d066](025d066)), closes [#1489](#1489)
* **IconButton:** change touchable area implementation ([#1504](#1504)) ([81777ad](81777ad))

### Features

* **Square:** add primitive Square component (WEB-2403) ([#1508](#1508)) ([4743a11](4743a11))
@AnaMontes11
Copy link
Copy Markdown
Contributor

AnaMontes11 commented Mar 2, 2026

Hi @atabel, I’m not seeing the same tokens in CSS as in the skins. Is this expected?

@AnaMontes11
Copy link
Copy Markdown
Contributor

AnaMontes11 commented Mar 2, 2026 •
edited
Loading

hi @atabel for consistency, the fileItem component should use the boxedRow component internally, but currently there are some issues. For example, the image doesn't respect the mediaSmall border radius. Could you adjust this to match the specs?
Example

Marcosld
Marcosld previously approved these changes Mar 4, 2026
View reviewed changes
@atabel atabel dismissed stale reviews from Marcosld and yceballost via b541363 March 5, 2026 10:10
@atabel
Copy link
Copy Markdown
Contributor Author

atabel commented Mar 5, 2026

Hi @atabel, I’m not seeing the same tokens in CSS as in the skins. Is this expected?

I've re-imported the tokens, it should be fine now

@atabel
Copy link
Copy Markdown
Contributor Author

atabel commented Mar 5, 2026

hi @atabel for consistency, the fileItem component should use the boxedRow component internally, but currently there are some issues. For example, the image doesn't respect the mediaSmall border radius. Could you adjust this to match the specs? Example

Changed to use BoxedRow

AnaMontes11
AnaMontes11 previously approved these changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AnaMontes11 AnaMontes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Marcosld Marcosld self-requested a review March 5, 2026 11:52
AnaMontes11
AnaMontes11 approved these changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AnaMontes11 AnaMontes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect @atabel !

@atabel atabel added this pull request to the merge queue Mar 5, 2026
Merged via the queue into master with commit 8b623cf Mar 5, 2026
11 checks passed
@atabel atabel deleted the atoledano-file-upload branch March 5, 2026 13:04
@tuentisre
Copy link
Copy Markdown
Collaborator

tuentisre commented Mar 6, 2026

🎉 This PR is included in version 16.53.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

yceballost pushed a commit that referenced this pull request Mar 12, 2026
@semantic-release-bot
chore(release): 16.53.0 [skip ci]
379fca9 
# [16.53.0](v16.52.0...v16.53.0) (2026-03-06)

### Bug Fixes

* **Input:** WEB-2382 Fix some misalignements and make startIcon small ([#1510](#1510)) ([686a092](686a092))

### Features

* **FileUpload:** new component ([#1489](#1489)) ([8b623cf](8b623cf))
* **skin:** WEB-2382 Movistar alignment p2 ([#1499](#1499)) ([86213c8](86213c8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Marcosld Marcosld Marcosld approved these changes

@yceballost yceballost yceballost approved these changes

@aweell aweell aweell approved these changes

@AnaMontes11 AnaMontes11 AnaMontes11 approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@atabel @aweell @AnaMontes11 @tuentisre @Marcosld @yceballost