Skip to content

feat(MainNavigationBar): topSlot support#1518

Merged
atabel merged 4 commits into
masterfrom
atoledano-navbar-topslot
Mar 13, 2026
Merged

feat(MainNavigationBar): topSlot support#1518
atabel merged 4 commits into
masterfrom
atoledano-navbar-topslot

Conversation

@atabel
Copy link
Copy Markdown
Contributor

@atabel atabel commented Mar 12, 2026

@atabel atabel requested review from Marcosld and yceballost March 12, 2026 13:58
@neo-sagittal neo-sagittal self-requested a review March 12, 2026 13:59
@neo-sagittal
Copy link
Copy Markdown

I'm reviewing this, it might take a few minutes, I'll add comments and update here when it's done.

@neo-sagittal
Copy link
Copy Markdown

I've checked the PR against the requirements in the ticket WEB-2378:

✅ Implement a top slot in the Main Navigation Bar component
✅ Configure the top slot to serve as a flexible container for multiple content types
✅ Add capability to manage dynamic content in the upper area of the Navigation Bar

Copy link
Copy Markdown

@neo-sagittal neo-sagittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Remember you can easily customize how your team reviews code!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 12, 2026

Size stats

master this branch diff
Total JS 16.1 MB 16.1 MB +1.42 kB
JS without icons 2 MB 2.01 MB +1.42 kB
Lib overhead 92.4 kB 92.4 kB 0 B
Lib overhead (gzip) 19.9 kB 19.9 kB 0 B

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 12, 2026

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-fce82v82p-flows-projects-65bb050e.vercel.app

Built with commit 1e63bde.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 12, 2026

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

Comment thread src/navigation-bar.tsx
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please

Comment thread src/navigation-bar.tsx
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

@atabel atabel Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the possibility to custom topBar background color

https://www.figma.com/design/Os5UfsnhLtQ9rnzmtcX8J4/%F0%9F%94%B8-Navigation-Bar-Specs?node-id=3860-9828&t=mj1qxxOUnCd2qsvC-4

yes, you can. Try with something like this:

topSlot={
    <ResponsiveLayout backgroundColor="paleviolet">
      <Placeholder height={24} />
    </ResponsiveLayout>
  }

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found also a bug with variant negative, maybe should I open another ticket for this?

Yes please, open a ticket. Not related with this PR

@atabel atabel requested a review from yceballost March 13, 2026 07:47
Copy link
Copy Markdown
Contributor

@yceballost yceballost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@atabel atabel enabled auto-merge March 13, 2026 09:58
@atabel atabel added this pull request to the merge queue Mar 13, 2026
Merged via the queue into master with commit 818748f Mar 13, 2026
11 checks passed
@atabel atabel deleted the atoledano-navbar-topslot branch March 13, 2026 10:25
@tuentisre
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 16.54.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Marcosld pushed a commit that referenced this pull request Mar 13, 2026
# [16.54.0](v16.53.0...v16.54.0) (2026-03-13)

### Bug Fixes

* **Hero:** Restore padding in hero mobile layouts ([#1514](#1514)) ([0513c35](0513c35))

### Features

* **Card:** Add space-between alignment for card slot ([#1516](#1516)) ([0900ebb](0900ebb))
* **Layout:** add extraLargeDesktop breakpoint ([#1503](#1503)) ([229ace4](229ace4))
* **MainNavigationBar:** topSlot support ([#1518](#1518)) ([818748f](818748f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants