Skip to content

chore(PreviewTools): fix editStory button in PreviewTools#1522

Merged
Marcosld merged 6 commits intomasterfrom
iceballos-fix-edit-link-previewTools
Apr 16, 2026
Merged

chore(PreviewTools): fix editStory button in PreviewTools#1522
Marcosld merged 6 commits intomasterfrom
iceballos-fix-edit-link-previewTools

Conversation

@yceballost
Copy link
Copy Markdown
Contributor

@yceballost yceballost commented Mar 20, 2026 •
edited
Loading

Edit Playroom button in PreviewTools doesn't open the url when the Playroom is embed in an iframe

yceballost
yceballost commented Mar 20, 2026
View reviewed changes
Comment thread playroom/preview-tools.css.ts
display: 'none', // Hide in Chrome/Safari
},

background: skinVars.colors.background,
Copy link
Copy Markdown
Contributor Author

@yceballost yceballost Mar 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a little fix when the previewtools has a floating state:
image

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 20, 2026 •
edited
Loading

Size stats

master this branch diff
Total JS 16.1 MB 16.1 MB -7 B
JS without icons 2.01 MB 2.01 MB -7 B
Lib overhead 92.5 kB 92.5 kB 0 B
Lib overhead (gzip) 19.9 kB 19.9 kB 0 B

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 20, 2026 •
edited
Loading

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-ifpipu7hv-flows-projects-65bb050e.vercel.app

Built with commit 9b33f70.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 20, 2026 •
edited
Loading

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@yceballost yceballost marked this pull request as ready for review March 23, 2026 16:30
@yceballost yceballost requested a review from Marcosld March 23, 2026 16:30
Marcosld
Marcosld reviewed Mar 24, 2026
View reviewed changes
Comment thread playroom/components/index.tsx
const editStory = () => {
if (window.location.href.includes('/preview')) {
window.open(window.location.href.replace('/preview', ''));
try {
Copy link
Copy Markdown
Contributor

@Marcosld Marcosld Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the new cases here, I don't think I understand

Copy link
Copy Markdown
Contributor Author

@yceballost yceballost Mar 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example, you need to open in preview mode to test it. Click in "code" icon, in the top right
https://mistica-web.vercel.app/playroom#?code=N4Igxg9gJgpiBcIA8BLAZgJwIYFsYB0A7AAmIGcMwBefEACwBcGAHM%2BAenZxTIZTCwBaAO4wARgDoAbjEowANhKzNm7ZvKwBPDBAg41GGFJQxh7AMQB%2BSLCoA5ACwBJAOYAPFwE4XAKRfMUACEwJwBBAA5QgDFQgBUAK1CxFwBlDyhhQIBVJzCxUIAtYVCnQIA2UIAFF0CABlCAdh9QnwAleLCQgHEALwYAWQBNQpLBwMqAYWiwUIAZKQBFQayAaRTQgFEnBdCACToADSwJiCz84QARHDiFifDijeKAdTmG2IKyZlCurL8yb7IK12gR6G361wuwQKTww60CUUCpkCdAWsQWEAOPXCGFRTk0XVC8guKwA8vFBBsScJav1Ak5BhMXKF4nUoAw7LsNl0VoELikJhdWny6SsyEyyrtZq1AhspM5Khd%2Bgd8qEpFAAEyq3ZuADWWTKKx2KSyLi6XWKswmu2hYliGxSIWYAEcUE6MJoGLsMF0AKxOlwk9U4FJ0ZgnWrxFY9WZOMR2TxSWo4QZQVpOBgHJ23BZPWorCZPKLqqA9CALKAoFahJ7CFxSeI7OkAZh5TcCLmECx9lTEC1qEzKFyiThS%2BRSs1mZVmDg2PiiBUnBxWuv6XdauycPQcprc2%2BTOoug3VKWE-ToLjsh4rTgwKAgOtCgTsKFqAGocGe6INX7tWv0XAAjK0syhAAahMsz9KEwhYIMOpPIEEBYCgwiaDgPopAs47xBAYgTIIYCWj4TjhPITikqsACuhArAwFwTFEPQrDqLg6hM8RYAwdA6gsxSMoSgStJ4FwLCsUE9KEZ4MBsJR%2BLEOqaGUbhZDArRYHQlZNgcEz9A4zAkhs1E%2BK%2Bgh0FgrRuE68hNk8By1CkMBZP0KT9P0BS6gsTZdLUAFuCktTqpRtQkswbbqpUPhuG4MCUQsr4oHYrQuAwr5ZJUrSVIM9w%2BuqaA%2BIQCwGj4sSYWUZAXHQYD7OEI4oCkJUyd8dCbDglFSD0LgoKEoRkM1YBdK0DRdEylQQKEJIHMITiKjstBEKQwgoGydA0CAAG1LUACkc2EOwAB8RAgAANCAXEwHgZAIAA2iA-QQMYvBYBgAD6dimCAAC6J2Lctl3wFdTZlLUH0AL5AA

fixed with this PR
https://mistica-fpkr7slii-flows-projects-65bb050e.vercel.app/playroom/preview/#?code=N4Igxg9gJgpiBcIA8BLAZgJwIYFsYB0A7AAmIGcMwBefEACwBcGAHM%2BAenZxTIZTCwBaNMwDWGAOxkANihTDpEAO5lBzDBABWMMA1UA2AKwAjYwAZDZmADoAbjEoxp1rM2btm0rAE8NEHB4YMLYoMErsAMQA-JCwVAByACwAkgDmAB6pAJypAFKpzCgAQmDJAIIAHGUAYmUAKpplxqkAyplQSkUAqsnlxmUAWkplyUX6ZQAKqUVmZRK5ZbkASprlpQDiAF4MALIAmoMje0UTAMI1YGUAMrYAintdANItZQCiybdlABJ0ABpYpwgXX6SgAIjh6rdThVhq9hgB1a4SOoDMjMMrrLr5MgYsiPL5FTavHYQ0ElAbwjAvIrVIphIp0W51W4QX6bCoYJnJbzrMrSUGPADymkEr0FSjMOyKyT2p1SZU0MygDHiX1e60eRVBLVOoKW2uljzI8v0XyuSyKr1sKQmoJ2v36ZVsUAATE6vulRF19I9Pi0uql1uthldTl8KcY6q8WqVmABHFBxjDeBhfDDrQxx1KCl04Fp0ZiAsyaR6bK7JYzxLK2Mw4PZQJbJBi-ONQ27wsyPU7w6ouqCbCC3KAoR5leFKVK2TSfaUAZk1s6KqSUt0ME2MtzMp30oOqyRa-RaVyu%2BiuiVeuWqAxPv0enp2q6WX2Sm0SgfSb7rolBexdLSUOx0Kk8Q-sOyQYCgECiGURTxCgZgANQ4IBdB7AhXxLDsqQAIxLFcZQAGqnFcOxlEoWB7KI8JFBAWAoEo3g4IYLS3EemgQMYpyCGAoa5MkFTSMkQpPAAroQjwMKCpzVJsjyiKkoinJoWAMHQoi3MMcp8kUSxZKCtyPKRmxlIBDCvCM%2BR1KI3j6OkXQwEsWB0COs6-KcOyJMwgqvGJuQIYIdBYEs6RxtIs7wr8ZgtDAXQ7C0Ow7AMnq3LO6xmNh6QtGYLoiWYgrMIuLoTLk6TpDAIm3AhKDxEsqQMAhXQTEsEx7DChgumguSELcPq5HULH6GQoJ0GAPwVPuKAtP15kYnQbw4CJtibKkKBlGUZBzWA6xLBI6zyhMEBlIKvxKMkdqfLQRCkEoKDKnQNAgNhZhmAApJdhDsAAfEQIAAL5AA

Copy link
Copy Markdown
Contributor

@Marcosld Marcosld Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm I see, but the old code doesn't even work without an iframe: https://mistica-web.vercel.app/playroom/frame.html#?themeName=Movistar_New&code=R_cE%28R_F%2C+null%2C+R_cE%28PreviewTools%2C+null+%29%0A%2C+R_cE%28ResponsiveLayout%2C+null%0A++%2C+R_cE%28Box%2C+%7B+paddingY%3A+24%2C%7D%0A++++%2C+R_cE%28Stack%2C+%7B+space%3A+40%2C%7D%0A++++++%2C+R_cE%28DataCard%2C+%7B%0A++++++++asset%3A+%0A++++++++++R_cE%28Circle%2C+%7B+backgroundColor%3A+colors.brandLow%2C+size%3A+40%2C%7D%0A++++++++++++%2C+R_cE%28IconShopRegular%2C+%7B+color%3A+colors.brand%2C%7D+%29%0A++++++++++%29%0A++++++++%2C%0A++++++++headline%3A+R_cE%28Tag%2C+%7B+type%3A+%22promo%22%2C%7D%2C+%22Headline%22%29%2C%0A++++++++title%3A+%22Title%22%2C%0A++++++++subtitle%3A+%22Subtitle%22%2C%0A++++++++description%3A+%22Description%22%2C%0A++++++++slot%3A+R_cE%28Placeholder%2C+null+%29%2C%0A++++++++buttonPrimary%3A+%0A++++++++++R_cE%28ButtonPrimary%2C+%7B+small%3A+true%2C+onPress%3A+%28%29+%3D%3E+%7B%7D%2C%7D%2C+%22Action%22%0A%0A++++++++++%29%0A++++++++%2C%0A++++++++buttonLink%3A+%0A++++++++++R_cE%28ButtonLink%2C+%7B+small%3A+true%2C+onPress%3A+%28%29+%3D%3E+%7B%7D%2C%7D%2C+%22Link%22%0A%0A++++++++++%29%0A++++++++%2C%7D%0A++++++%29%0A++++%29%0A++%29%0A%29%29 why?

Copy link
Copy Markdown
Contributor Author

@yceballost yceballost Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change from the latest versions of Playroom because now render "Preview mode" in an iframe

@Marcosld Marcosld added this pull request to the merge queue Mar 27, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 27, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026 •
edited
Loading

Screenshot tests report

✔️ All passing

@atabel atabel added this pull request to the merge queue Apr 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 15, 2026
@Marcosld Marcosld added this pull request to the merge queue Apr 16, 2026
Merged via the queue into master with commit f2c0a1c Apr 16, 2026
11 checks passed
@Marcosld Marcosld deleted the iceballos-fix-edit-link-previewTools branch April 16, 2026 07:49
@tuentisre
Copy link
Copy Markdown
Collaborator

tuentisre commented Apr 17, 2026

🎉 This PR is included in version 16.59.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atabel atabel atabel approved these changes

@Marcosld Marcosld Marcosld approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yceballost @tuentisre @atabel @Marcosld @ieduardogf