feat(menu): add MenuItem action support for onPress, href, and to#1528
Conversation
|
Hi @MurilloLeoni, is this PR ready to review? Please, include some reviewers like @Marcosld and me Please, include in PR body the link of the Jira issue Thanks!! 🤟 |
|
Hi! Thank you very much for the feedback and for taking the time to review this PR. 🙂 I’ve added the Jira ticket link to the PR description as requested. For context, the ticket was later cancelled since the development was handled directly by our team, but this is the related one: Regarding the implementation, I initially introduced an I’m currently updating the |
|
Hi, sorry for the delay on my side. We had some high-priority tasks in our team and needed to focus on those deliveries, so this one ended up being paused for a bit. About this PR: I saw that the changes were already approved, but the pipeline is still failing. I checked the errors and they seem to be related to pipeline configuration (e.g., missing token in checkout, accessibility audit failing in CI, and Azure upload issue), not directly to the code changes. Could you please clarify how the merge process works in this case? Should I take any action to fix these pipeline issues, or is this something handled on your side? Thanks! |
I think the problems of the actions is not by your fault. I think the PR can be merge when @Marcosld can do that for the next release |
Adds an
actionprop to MenuItem.Supports:
Jira: https://jira.tid.es/browse/OBVIVO-3412