ACCOUNT-30901 add support for tracks in video component#1540
Merged
Conversation
|
Size stats
|
|
Deploy preview for mistica-web ready!
Deployed with vercel-action |
|
Accessibility report ℹ️ You can run this locally by executing |
andyindahouse
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for <track> elements (subtitles, captions, etc.) to the Video component by introducing a new tracks prop and corresponding VideoTrack type, exporting the new type publicly, and updating the Video story with a sample WebVTT subtitle file.
Changes:
- New
VideoTracktype andtracksprop onVideo, rendered as<track>children;crossOrigin="anonymous"is automatically applied when tracks are present. - Public re-export of
VideoTrackfrom the package entry point. - Story update with a demo
.vttsubtitle file to exercise the new feature.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/video.tsx | Adds VideoTrack type, tracks prop, renders <track> elements, sets crossOrigin when tracks exist. |
| src/index.tsx | Exports the new VideoTrack type. |
| src/stories/video-story.tsx | Adds a tracks example using the new VTT file in the Default story. |
| src/stories/videos/test-subtitles.vtt | New WebVTT subtitle file used by the story. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| disableRemotePlayback | ||
| muted={muted} | ||
| loop={loop} | ||
| crossOrigin={tracks ? 'anonymous' : undefined} |
|
Size stats
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Marcosld
reviewed
May 18, 2026
Marcosld
approved these changes
May 20, 2026
…nd toggle functionality
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
yceballost
reviewed
May 20, 2026
Marcosld
reviewed
May 21, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
aweell
approved these changes
May 25, 2026
Marcosld
reviewed
May 26, 2026
Comment on lines
+129
to
+134
| /** | ||
| * Sets the display mode of a track by its index. | ||
| * - 'showing': track is visible | ||
| * - 'disabled': track is inactive | ||
| */ | ||
| setTrackMode: (index: number, mode: 'showing' | 'disabled') => void; |
Contributor
There was a problem hiding this comment.
Is the goal of this method changing the subtitles that are currently enabled? Perhaps we should expose a simpler API, something like:
setActiveSubtitleIndex: (i: number) => void
```tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.