fix(Sheet): make close button clickable on iOS#1549
Merged
Conversation
Move the dismiss button outside the scrollable section so it's not clipped by the parent's overflowY:auto, which on iOS prevented taps on the button when positioned outside the visible scroll area. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Size stats
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an iOS Safari interaction issue in the Sheet component by moving the dismiss (close) button out of the scrollable container so it doesn’t get clipped by overflowY: auto, restoring tap/click behavior.
Changes:
- Hoist the Sheet dismiss button to be a sibling of the scrollable
<section>instead of a child. - Keep visual placement via existing
styles.dismissButtonabsolute positioning while avoiding iOS overflow clipping.
Comments suppressed due to low confidence (1)
src/sheet-common.tsx:263
- The dismiss (close) button is now rendered outside the element with
role="dialog"/aria-modal. This can hurt screen reader semantics because the close control may no longer be considered part of the dialog. Consider moving therole="dialog"(and relatedaria-*) to a wrapper that includes both the close button and the scrollable area, or keep thesectionas the dialog container and introduce an inner scrollable element (withoverflowY: auto) so the close button can remain inside the dialog but outside the scroll clipping context.
<section
role="dialog"
aria-modal="true"
aria-labelledby={modalTitleId}
onScroll={onScroll}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Deploy preview for mistica-web ready!
Deployed with vercel-action |
|
Screenshot tests report ✔️ All passing |
|
Accessibility report ℹ️ You can run this locally by executing |
Collaborator
|
🎉 This PR is included in version 16.63.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 16.64.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
joaoelias1921
pushed a commit
to joaoelias1921/mistica-web
that referenced
this pull request
Jun 9, 2026
## [16.63.1](Telefonica/mistica-web@v16.63.0...v16.63.1) (2026-05-22) ### Bug Fixes * **Inline:** allow children to expand ([Telefonica#1546](Telefonica#1546)) ([36a8e9b](Telefonica@36a8e9b)) * **Sheet:** make close button clickable on iOS ([Telefonica#1549](Telefonica#1549)) ([85be767](Telefonica@85be767))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<section>so it is not clipped by the parent'soverflowY: auto.sheetTopDraggingArea) restores tap interaction without affecting visual placement.