Skip to content

feat(skin): replace vivo-new with vivo, and add vivo-evolution#1608

Open
brtbrt wants to merge 3 commits into
masterfrom
mbertamini/1595-vivo-skins
Open

feat(skin): replace vivo-new with vivo, and add vivo-evolution#1608
brtbrt wants to merge 3 commits into
masterfrom
mbertamini/1595-vivo-skins

Conversation

@brtbrt

@brtbrt brtbrt commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Closes #1595. Part of #626 — Major release plan 17.0.0.

Changes

  • Renames vivo-new skin to vivo (replacing the old one)
  • Introduces vivo-evolution as a copy of the current vivo-new values, ready to evolve independently after the major release

Stack position — 1 of 9

This PR is the first in the stack and targets master directly.

→ #1608 (this) → master        ← merge first
  #1609         → branch-1595
  ...

For the full merge strategy, see #626. Do not merge out of order.

Copilot AI review requested due to automatic review settings June 30, 2026 19:20
@brtbrt brtbrt changed the title Feat(skin) move replace vivo with vivo-new, and add vivo-evolution feat(skin) move replace vivo with vivo-new, and add vivo-evolution Jun 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

Size stats

master this branch diff
Total JS 17 MB 17 MB -1.87 kB
JS without icons 2.07 MB 2.07 MB -1.91 kB
Lib overhead 96.3 kB 96.3 kB +35 B
Lib overhead (gzip) 21.1 kB 21.1 kB +15 B

id: 'components-carousels-carousel--default',
device: 'MOBILE_IOS',
skin: VIVO_NEW_SKIN,
skin: VIVO_SKIN,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for these kind of tests: do we want to add vivo-evolution too already?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, supporting 2 test for vivo maybe is too much? I dont want to die drowned between screenshots

import {openStoryPage, screen} from '../test-utils';

const SKINS = ['Movistar', 'O2', 'Vivo-new', 'Telefonica', 'Blau', 'O2-new', 'Tu', 'Esimflag'] as const;
const SKINS = ['Movistar', 'O2', 'Vivo', 'Telefonica', 'Blau', 'O2-new', 'Tu', 'Esimflag'] as const;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here: do we add vivo-evolution already?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaand same here. do we add vivo-evolution too. WDYT? I see it a good add

Comment thread src/image.tsx
skinName === VIVO_SKIN ? (
<VivoLogo style={{width: '10%', minWidth: 24, maxWidth: 48}} />
) : skinName === VIVO_NEW_SKIN ? (
skinName === VIVO_SKIN || skinName === VIVO_EVOLUTION_SKIN ? (

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double checking this: we are ok with this right?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@brtbrt brtbrt added the AI AI Generated label Jun 30, 2026
@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

Deploy preview for mistica-web ready!

Project:mistica-web
Status: ✅  Deploy successful!
Preview URL:https://mistica-nrb1ljtyo-flows-projects-65bb050e.vercel.app
Latest Commit:0021439

Deployed with vercel-action

@brtbrt brtbrt self-assigned this Jun 30, 2026
@brtbrt brtbrt requested a review from a team June 30, 2026 19:27
@brtbrt brtbrt changed the title feat(skin) move replace vivo with vivo-new, and add vivo-evolution feat(skin) replace vivo-new with vivo, and add vivo-evolution Jun 30, 2026
@brtbrt brtbrt changed the title feat(skin) replace vivo-new with vivo, and add vivo-evolution feat(skin): replace vivo-new with vivo, and add vivo-evolution Jun 30, 2026
Copilot AI review requested due to automatic review settings June 30, 2026 20:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Telefonica Telefonica deleted a comment from github-actions Bot Jun 30, 2026
@Telefonica Telefonica deleted a comment from github-actions Bot Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why these screenshots are new? 🤔

I could understand if the name of the screenshots include "evolution" but is not the case

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we've just passed from vivo-new to be vivo, and vivo used to be different right?

id: 'components-carousels-carousel--default',
device: 'MOBILE_IOS',
skin: VIVO_NEW_SKIN,
skin: VIVO_SKIN,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, supporting 2 test for vivo maybe is too much? I dont want to die drowned between screenshots

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wea have run tests using two Vivo models... and other tests without this approach... I feel like there are quite a few inconsistencies here.

wdyt? maybe is a task for the future

Comment thread src/image.tsx
skinName === VIVO_SKIN ? (
<VivoLogo style={{width: '10%', minWidth: 24, maxWidth: 48}} />
) : skinName === VIVO_NEW_SKIN ? (
skinName === VIVO_SKIN || skinName === VIVO_EVOLUTION_SKIN ? (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@github-actions

Copy link
Copy Markdown

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI AI Generated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Vivo New skin

3 participants