-
Notifications
You must be signed in to change notification settings - Fork 22
feat(skin): replace vivo-new with vivo, and add vivo-evolution #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
This file was deleted.
Large diffs are not rendered by default.
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why these screenshots are new? 🤔 I could understand if the name of the screenshots include "evolution" but is not the case
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. because we've just passed from vivo-new to be vivo, and vivo used to be different right? |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| import {openStoryPage, screen} from '../test-utils'; | ||
| import {VIVO_NEW_SKIN} from '../skins/constants'; | ||
| import {VIVO_SKIN} from '../skins/constants'; | ||
|
|
||
| import type {ElementHandle} from 'puppeteer'; | ||
|
|
||
|
|
@@ -75,11 +75,11 @@ test('Carousel mobile with controls and autoplay', async () => { | |
| expect(await page.screenshot()).toMatchImageSnapshot(); | ||
| }); | ||
|
|
||
| test('Carousel mobile in Vivo new', async () => { | ||
| test('Carousel mobile in Vivo', async () => { | ||
| const page = await openStoryPage({ | ||
| id: 'components-carousels-carousel--default', | ||
| device: 'MOBILE_IOS', | ||
| skin: VIVO_NEW_SKIN, | ||
| skin: VIVO_SKIN, | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for these kind of tests: do we want to add vivo-evolution too already?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. mmm, supporting 2 test for vivo maybe is too much? I dont want to die drowned between screenshots |
||
| }); | ||
|
|
||
| expect(await page.screenshot()).toMatchImageSnapshot(); | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wea have run tests using two Vivo models... and other tests without this approach... I feel like there are quite a few inconsistencies here. wdyt? maybe is a task for the future |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import {openStoryPage, screen} from '../test-utils'; | ||
|
|
||
| const SKINS = ['Movistar', 'O2', 'Vivo-new', 'Telefonica', 'Blau', 'O2-new', 'Tu', 'Esimflag'] as const; | ||
| const SKINS = ['Movistar', 'O2', 'Vivo', 'Telefonica', 'Blau', 'O2-new', 'Tu', 'Esimflag'] as const; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here: do we add vivo-evolution already? |
||
|
|
||
| test.each(SKINS)('Components in %s', async (skin) => { | ||
| await openStoryPage({ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we want both for now @yceballost (?)