feat(skin)!: replace O2 skin with O2-new#1616
Open
brtbrt wants to merge 10 commits into
Open
Conversation
## Summary - Bumps `@telefonica/acceptance-testing` from `5.3.1` to `5.4.0`. - Updates `yarn.lock` and the Yarn zero-install cache accordingly. ## Test plan - [x] Verify CI passes (unit tests, acceptance tests, lint). - [x] Confirm the Terraform plan (if applicable) is unaffected. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…1612) Closes #1613 ## Summary Fixes a validation regression where a mandatory `Select` (no `optional` prop) did not display the "this field is required" error after submitting a `Form` on the desktop (non-native) variant. ## Root cause Introduced in **16.45.0** (commit `d2cf20071`, #1464). That change removed the native `required` DOM attribute from desktop inputs and moved required-detection into the field registration (`required ?? input.required` in `form.tsx`). `useFieldProps` was updated to register `required: !optional`, but `Select` uses its own `register` call and was never updated. On desktop the underlying input no longer reports `input.required`, so `validateFields` never flagged the field as mandatory. The native/mobile variant was unaffected because it renders a real `<select required>` element, so `input.required` stayed `true`. ## Fix Pass `required: !optional` in `Select`'s `register` call (aligning it with `useFieldProps`), and add `optional` to the effect's dependency array. Before: <img width="1216" height="944" alt="Screenshot 2026-07-01 at 12 31 35" src="https://github.com/user-attachments/assets/72d7759a-a5a0-474b-8d42-4f417f89a60e" /> Now: <img width="1207" height="762" alt="Screenshot 2026-07-01 at 12 31 51" src="https://github.com/user-attachments/assets/ac1d7860-63e9-4cb9-88c6-551a48c26860" />
# [16.70.0](v16.69.0...v16.70.0) (2026-07-01) ### Bug Fixes * **Select:** fix Select validation on desktop devices Ref: WEB-2450 ([#1612](#1612)) ([59aafa3](59aafa3)), closes [#1613](#1613) [#1464](#1464) ### Features * **Chore:** Include feedback into mistica-figma skill ([#1594](#1594)) ([2b960dc](2b960dc))
|
Size stats
|
|
Deploy preview for mistica-web ready!
Deployed with vercel-action |
Complete the O2-new cleanup missed in the initial replacement: - playroom/themes.tsx: rename O2_New/O2_New_iOS to O2/O2_iOS so the Playroom O2 theme resolves (fixes the TypeScript build). - audit-accessibility: audit the O2 skin instead of the removed O2-new. - generate-design-tokens and import-mistica-icons: drop the stale o2-new entries so regeneration does not recreate the deleted files. - docs: point to getO2Skin/o2Palette and a single o2 skin row.
yceballost
reviewed
Jul 1, 2026
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@telefonica/mistica", | |||
| "version": "16.69.0", | |||
Contributor
There was a problem hiding this comment.
wrong version? is it a major right? 17.0.0
Contributor
Author
There was a problem hiding this comment.
actually, I'd keep the version the same. we're gonna change it onto the last merge (cleansing).
#1615
what you see here is a master pull, which is on 16.70 already, but since o2new is merging against remove-tu-skin, which wasn't so in sync with master, it shows up like a diff. no worries, it's ok :). but good eagle eye
Contributor
Author
There was a problem hiding this comment.
yes don't worry! tl;dr this is a master change. if I opened the PR against master, you wouldn't see the diff
|
Accessibility report ℹ️ You can run this locally by executing |
The O2-new skin was removed from all acceptance test parametrizations when O2-new replaced O2. These snapshot images are no longer generated and are removed as obsolete output.
Marcosld
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1597. Part of #626 — Major release plan 17.0.0.
Changes
O2skin definition with theO2-newdesign (beyondBlue palette, new border radii, updated icon styles).O2-newskin entirely —O2_SKINis now the canonical constant.src/skins/o2-new.tsx,src/logo-o2-new.tsx,src/logo-o2-new-shell.tsx,css/o2-new.css.o2-newreferences in the accessibility audit action, the design-token and icon-import generators, and the docs.Stack position — 3 of 9
This PR is stacked on top of the skin-cleanup series and must not merge into
masterdirectly:vivo-newwithvivoand addvivo-evolution(base:master)Tuskin (base:mbertamini/1595-vivo-skins)mbertamini/1596-remove-tu-skin)Merge #1608 and #1609 first; GitHub will automatically retarget this PR to
masteras each parent lands.For the full merge strategy, see #626.