-
Notifications
You must be signed in to change notification settings - Fork 22
feat(skin)!: replace O2 skin with O2-new #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mbertamini/1596-remove-tu-skin
Are you sure you want to change the base?
Changes from all commits
e4a2a91
59aafa3
5712865
9580f9c
48e3e80
1b03319
1684909
cd3b5ef
951aa59
2b825ce
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Large diffs are not rendered by default.
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. expected change?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes don't worry! tl;dr this is a master change. if I opened the PR against |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import {openStoryPage, screen} from '../test-utils'; | ||
|
|
||
| import type {Device} from '../test-utils'; | ||
|
|
||
| test.each(['DESKTOP', 'MOBILE_IOS'] as Array<Device>)( | ||
| 'form fields with required errors after submit validation on %s', | ||
| async (device) => { | ||
| await openStoryPage({ | ||
| id: 'patterns-forms-form-with-automatic-state-management--default', | ||
| device, | ||
| }); | ||
|
|
||
| await (await screen.findByText('Send')).click(); | ||
|
|
||
| const fieldWrapper = await screen.findByTestId('form-wrapper'); | ||
| const image = await fieldWrapper.screenshot(); | ||
|
|
||
| expect(image).toMatchImageSnapshot(); | ||
| } | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong version? is it a major right? 17.0.0
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, I'd keep the version the same. we're gonna change it onto the last merge (cleansing).
#1615
what you see here is a master pull, which is on 16.70 already, but since o2new is merging against remove-tu-skin, which wasn't so in sync with master, it shows up like a diff. no worries, it's ok :). but good eagle eye