Skip to content

feat(skin)!: replace Movistar skin with Movistar-new#1620

Merged
brtbrt merged 26 commits into
masterfrom
mbertamini/1617-remove-movistar-new
Jul 14, 2026
Merged

feat(skin)!: replace Movistar skin with Movistar-new#1620
brtbrt merged 26 commits into
masterfrom
mbertamini/1617-remove-movistar-new

Conversation

@brtbrt

@brtbrt brtbrt commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Part of #626 — Major release plan 17.0.0.

Changes

  • Replaces the movistar-new skin with movistar, removing the old movistar skin and promoting movistar-new as the canonical movistar skin.
  • Deletes css/movistar-new.css, src/skins/movistar-new.tsx, and the movistar-new logo files; the canonical movistar counterparts now carry the promoted content.
  • Removes the Movistar-new skin name, MOVISTAR_NEW_SKIN, getMovistarNewSkin, movistarNewPalette, and MovistarNewLogo from the public API and internal wiring.
  • Updates Storybook, Playroom, stories, screenshot tests, docs, and token tooling to reference the single movistar skin, and moves the Movistar Sans font mapping onto the canonical movistar skin.

Note on the logo

Unlike the O2 change (where the base and -new logos were identical), the Movistar logo was genuinely redesigned. The movistar-new logo content was therefore promoted into logo-movistar.tsx / logo-movistar-shell.tsx so the canonical skin ships the new artwork.

Stack position

This is subtask 4 of 10 in the stacked PR chain. It targets the branch from #1597 and can only be merged after #1597 lands on master.

See #626 for the full merge strategy and ordering.

Closes #1617.

brtbrt added 12 commits June 30, 2026 21:19
Remove the Tu skin entirely: skin definition, logo files and their
shells, the registry entry, the public exports, and all related
stories, screenshot tests, snapshots, storybook/playroom wiring, and
docs.

BREAKING CHANGE: the Tu skin has been removed. The TuLogo component and
the TU_SKIN, getTuSkin, and tuPalette exports are no longer available.
Closes #1597. Part of #626 — Major release plan 17.0.0.
Complete the O2-new cleanup missed in the initial replacement:

- playroom/themes.tsx: rename O2_New/O2_New_iOS to O2/O2_iOS so the
  Playroom O2 theme resolves (fixes the TypeScript build).
- audit-accessibility: audit the O2 skin instead of the removed O2-new.
- generate-design-tokens and import-mistica-icons: drop the stale
  o2-new entries so regeneration does not recreate the deleted files.
- docs: point to getO2Skin/o2Palette and a single o2 skin row.
Closes #1617. Part of #626 — Major release plan 17.0.0.
Copilot AI review requested due to automatic review settings July 1, 2026 22:59
@brtbrt brtbrt added the AI AI Generated label Jul 1, 2026
@brtbrt brtbrt mentioned this pull request Jul 1, 2026
@brtbrt brtbrt linked an issue Jul 1, 2026 that may be closed by this pull request
@brtbrt brtbrt self-assigned this Jul 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is part of the 17.0.0 breaking-changes plan and consolidates Movistar skins by promoting the former movistar-new implementation (tokens + assets) to become the canonical movistar skin, while removing the old legacy movistar and all movistar-new public API surface.

Changes:

  • Removes movistar-new from the public API/types and internal wiring (MOVISTAR_NEW_SKIN, getMovistarNewSkin, movistarNewPalette, MovistarNewLogo, etc.).
  • Promotes the movistar-new palette/tokens and logo artwork into the canonical Movistar skin/logo implementation.
  • Updates Storybook, Playroom, screenshot/accessibility tooling, and docs to use only Movistar.

Reviewed changes

Copilot reviewed 29 out of 31 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/test-utils/index.tsx Updates default skin references from Movistar-new to Movistar for tests/helpers.
src/skins/utils.tsx Removes movistar-new branch from getSkinByName.
src/skins/types/index.tsx Removes 'Movistar-new' from KnownSkinName.
src/skins/movistar.tsx Replaces legacy Movistar tokens with the promoted movistar-new token set.
src/skins/movistar-new.tsx Deletes the movistar-new skin implementation.
src/skins/constants.tsx Removes MOVISTAR_NEW_SKIN constant.
src/logo.tsx Removes Movistar-new logo wiring and public export.
src/logo-movistar.tsx Promotes the new Movistar logo artwork/logic into the canonical Movistar logo.
src/logo-movistar-shell.tsx Updates Movistar logo viewBox to match promoted artwork size.
src/logo-movistar-new.tsx Deletes Movistar-new logo implementation.
src/logo-movistar-new-shell.tsx Deletes Movistar-new logo shell.
src/index.tsx Removes Movistar-new exports and re-exports only canonical Movistar APIs.
src/stories/logo-story.tsx Updates story controls/options to remove Movistar-new.
src/screenshot_tests/tooltip-screenshot-test.tsx Removes legacy Movistar-new reference from screenshot test setup.
src/screenshot_tests/popover-screenshot-test.tsx Removes legacy Movistar-new reference from screenshot test setup.
src/screenshot_tests/logo-screenshot-test.tsx Removes Movistar-new from the skins list used in logo screenshots.
playroom/themes.tsx Renames Playroom theme config from Movistar_New to Movistar.
playroom/frame-component.tsx Updates default theme + font-family mapping to canonical Movistar.
playroom/components/index.tsx Updates Playroom theme selector/icon mapping to canonical Movistar.
packages/generate-design-tokens/index.js Removes movistar-new from the known-skins token generation list.
doc/theme-config.md Updates docs to reference getMovistarSkin()/movistarPalette instead of *New* APIs.
doc/patterns.md Updates theme examples to use getMovistarSkin().
doc/llms/llms.md Updates LLM guidance/examples and available-skins list to remove movistar-new.
doc/fonts.md Updates skin↔font mapping docs to reflect new canonical Movistar font.
.storybook/themes.tsx Removes Storybook Movistar_New theme.
.storybook/theme-selector-addon/manager.tsx Updates default selected skin from Movistar-new to Movistar.
.storybook/preview.tsx Removes query-param support for MOVISTAR_NEW_SKIN and updates font-family logic.
.storybook/colors.ts Removes Movistar-new from available skins and promotes new colors to Movistar.
.github/actions/audit-accessibility/main.js Updates accessibility audit skin list to use canonical Movistar.
Comments suppressed due to low confidence (1)

src/logo-movistar.tsx:17

  • In dark mode, the logo isotype color is currently taken from colors.brand (light-mode palette). getMovistarSkin() defines a different darkModeColors.brand value, so this can render the wrong blue when isDarkMode is true.
    const color =
        colorProp ||
        (isDarkMode
            ? colors.brand
            : {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@brtbrt brtbrt changed the title feat(skin)!: replace Movistar skin with Movistar-new feat(skin): replace Movistar skin with Movistar-new Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Deploy preview for mistica-web ready!

Project:mistica-web
Status: ✅  Deploy successful!
Preview URL:https://mistica-fpyrmttmt-flows-projects-65bb050e.vercel.app
Latest Commit:807215f

Deployed with vercel-action

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

brtbrt added 2 commits July 2, 2026 01:19
The Movistar-new skin no longer exists after its promotion to the
canonical Movistar skin, so its committed image snapshots are obsolete.
Regeneration does not delete obsolete image files, so remove them here.
These tests were pinned to the legacy Movistar skin because they were
unstable on Movistar-new. Since Movistar now is the former Movistar-new,
the warning still applies; reword it instead of dropping it.
brtbrt and others added 5 commits July 2, 2026 03:09
The O2-new skin was removed from all acceptance test parametrizations
when O2-new replaced O2. These snapshot images are no longer generated
and are removed as obsolete output.
# Conflicts:
#	.github/actions/audit-accessibility/main.js
#	.storybook/preview.tsx
#	.storybook/themes.tsx
#	doc/fonts.md
#	doc/llms/llms.md
#	packages/generate-design-tokens/index.js
#	playroom/components/index.tsx
#	playroom/frame-component.tsx
#	playroom/themes.tsx
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-movistar-2-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-movistar-3-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-movistar-alternative-2-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-movistar-alternative-3-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-movistar-dark-mode-2-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-movistar-dark-mode-3-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-movistar-inverse-2-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-movistar-inverse-3-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-movistar-inverse-and-dark-mode-2-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-movistar-inverse-and-dark-mode-3-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-o-2-2-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-o-2-3-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-o-2-4-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-o-2-alternative-2-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-o-2-alternative-3-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-o-2-alternative-4-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-o-2-dark-mode-2-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-o-2-dark-mode-3-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-o-2-inverse-2-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-o-2-inverse-3-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-o-2-inverse-and-dark-mode-2-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-o-2-inverse-and-dark-mode-3-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-vivo-2-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-vivo-3-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-vivo-alternative-2-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-vivo-alternative-3-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-vivo-dark-mode-2-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-vivo-dark-mode-3-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-vivo-inverse-2-snap.png
#	src/__screenshot_tests__/__image_snapshots__/private-skin-components-screenshot-test-tsx-components-in-vivo-inverse-and-dark-mode-2-snap.png
#	src/__screenshot_tests__/counter-screenshot-test.tsx
#	src/__stories__/logo-story.tsx
#	src/index.tsx
#	src/skins/utils.tsx
#	src/test-utils/index.tsx
@brtbrt
brtbrt requested a review from a team as a code owner July 13, 2026 21:26
@brtbrt
brtbrt changed the base branch from mbertamini/1597-remove-o2new-skin to master July 13, 2026 21:49
@brtbrt brtbrt changed the title feat(skin): replace Movistar skin with Movistar-new feat(skin)!: replace Movistar skin with Movistar-new Jul 13, 2026
@brtbrt
brtbrt force-pushed the mbertamini/1617-remove-movistar-new branch from 3a5cf19 to cb9f933 Compare July 13, 2026 21:57
@github-actions

Copy link
Copy Markdown

Size stats

master this branch diff
Total JS 15.9 MB 15.8 MB -61.2 kB
JS without icons 1.99 MB 1.93 MB -60.9 kB
Lib overhead 96.3 kB 96.3 kB -28 B
Lib overhead (gzip) 21.1 kB 21.2 kB +47 B

Comment thread .storybook/preview.tsx Outdated
Comment thread doc/fonts.md Outdated
Comment thread doc/llms/llms.md Outdated
Comment thread playroom/components/index.tsx Outdated
@brtbrt
brtbrt requested a review from yceballost July 14, 2026 10:44
@aweell
aweell self-requested a review July 14, 2026 11:02
@brtbrt
brtbrt added this pull request to the merge queue Jul 14, 2026
Comment thread doc/fonts.md
| `esimflag` | `getEsimflagSkin()` | `'On Air'` |
| Skin | Getter function | Font family |
| --------------------- | ------------------------ | ------------------- |
| `movistar` _(legacy)_ | `getMovistarSkin()` | `'On Air'` |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should legacy be removed?

Merged via the queue into master with commit 7822d16 Jul 14, 2026
12 checks passed
@tuentisre

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 16.72.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tuentisre

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 17.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI AI Generated released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Movistar New skin

5 participants