feat(Chore)!: replace data-component-name with data-testid by brtbrt · Pull Request #1622 · Telefonica/mistica-web

brtbrt · 2026-07-02T02:17:51Z

Closes #1598. Part of #626 — Major release plan 17.0.0.

Changes

Removes the deprecated data-component-name attribute from getPrefixedDataAttributes, which now emits only data-testid. This covers every component that renders test attributes through the shared utility.
Replaces the three hardcoded data-component-name attributes with data-testid: BurgerMenuIcon and NavigationBarActionGroup in navigation-bar.tsx, and Dialog in dialog.tsx.
Drops the redundant data-component-name on FixedFooter, which already carried a matching data-testid.

Tests

No test queried by data-component-name; the dedicated testid-test.tsx and all other selectors already use data-testid, so no test changes were required.
Verified locally: testid-test (15 passed), dialog-test (16 passed), and main-navigation-bar-test (2 passed).

Stack position — 5 of 10

This PR targets the branch from #1617 and can only be merged after #1617 lands on master. GitHub will retarget it to master automatically as the parent merges.

For the full merge strategy and ordering, see #626. Do not merge out of order.

Remove the Tu skin entirely: skin definition, logo files and their shells, the registry entry, the public exports, and all related stories, screenshot tests, snapshots, storybook/playroom wiring, and docs. BREAKING CHANGE: the Tu skin has been removed. The TuLogo component and the TU_SKIN, getTuSkin, and tuPalette exports are no longer available.

…move-o2new-skin

Closes #1597. Part of #626 — Major release plan 17.0.0.

Complete the O2-new cleanup missed in the initial replacement: - playroom/themes.tsx: rename O2_New/O2_New_iOS to O2/O2_iOS so the Playroom O2 theme resolves (fixes the TypeScript build). - audit-accessibility: audit the O2 skin instead of the removed O2-new. - generate-design-tokens and import-mistica-icons: drop the stale o2-new entries so regeneration does not recreate the deleted files. - docs: point to getO2Skin/o2Palette and a single o2 skin row.

…move-o2new-skin

Closes #1617. Part of #626 — Major release plan 17.0.0.

The Movistar-new skin no longer exists after its promotion to the canonical Movistar skin, so its committed image snapshots are obsolete. Regeneration does not delete obsolete image files, so remove them here.

These tests were pinned to the legacy Movistar skin because they were unstable on Movistar-new. Since Movistar now is the former Movistar-new, the warning still applies; reword it instead of dropping it.

…ng issue Replace the free-text TODO comments with the `// todo <link> <description>` pattern, pointing at the tracking issue for the screenshot instability.

The O2-new skin was removed from all acceptance test parametrizations when O2-new replaced O2. These snapshot images are no longer generated and are removed as obsolete output.

…-remove-movistar-new

Removes the deprecated data-component-name attribute across all components. getPrefixedDataAttributes now emits only data-testid, and the three hardcoded data-component-name attributes (BurgerMenuIcon, NavigationBarActionGroup, Dialog) are replaced; the duplicate on FixedFooter is dropped. Ref: #1598

Copilot

Pull request overview

This PR is part of the 17.0.0 breaking-change plan and aims to complete the migration away from the deprecated data-component-name attribute by standardizing on data-testid across Mistica components and shared DOM utilities.

Changes:

Updates getPrefixedDataAttributes to stop emitting data-component-name when a componentName is provided, emitting only data-testid.
Replaces hardcoded data-component-name usages with data-testid in navigation-bar.tsx and dialog.tsx.
Removes a redundant data-component-name from FixedFooterLayout, keeping data-testid only.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/utils/dom.tsx	Adjusts the shared data-attribute utility to prefer `data-testid`.
src/navigation-bar.tsx	Replaces remaining hardcoded `data-component-name` attributes with `data-testid`.
src/fixed-footer-layout.tsx	Removes redundant deprecated attribute, keeping `data-testid`.
src/dialog.tsx	Replaces hardcoded `data-component-name` with `data-testid` on the dialog container.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

brtbrt · 2026-07-14T15:52:04Z

this was bad by previous PRs. fixed here

brtbrt · 2026-07-14T15:52:19Z

same here: fixed on this PR

github-actions · 2026-07-14T16:02:24Z

Size stats

	master	this branch	diff
Total JS	15.8 MB	15.8 MB	-25 B
JS without icons	1.93 MB	1.93 MB	-25 B
Lib overhead	96.3 kB	96.1 kB	-124 B
Lib overhead (gzip)	21.2 kB	21.1 kB	-29 B

brtbrt · 2026-07-14T16:28:03Z

 .directory
 .DS_Store
 .idea/
+mistica-web.iml


I use intellij, I don't want to further commit it, unless explicitly

Remove the `never` restriction on `component-name` in `DataAttributes`, making it a valid key for data attribute objects.

this is blocking the PR while Marcos is on vacations + reviewed by Abel. We're good to go

tuentisre · 2026-07-15T19:56:38Z

🎉 This PR is included in version 16.72.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

tuentisre · 2026-07-15T23:22:01Z

🎉 This PR is included in version 17.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

brtbrt and others added 22 commits June 30, 2026 21:19

move replace vivo with vivo-new, and add vivo-evolution

7729cf2

update failing screenshot

cebff06

update audit for the new skins

0021439

chore(ci): run CI on all PRs regardless of base branch

31801be

Merge branch 'mbertamini/1596-remove-tu-skin' into mbertamini/1597-re…

9580f9c

…move-o2new-skin

feat(skin)!: replace O2 skin with O2-new

48e3e80

Closes #1597. Part of #626 — Major release plan 17.0.0.

fix(skin): remove unused import in icon-success after O2-new cleanup

1b03319

fix(skin): remove remaining Tu skin css and config references

44f814d

Merge branch 'mbertamini/1596-remove-tu-skin' into mbertamini/1597-re…

cd3b5ef

…move-o2new-skin

feat(skin)!: replace Movistar skin with Movistar-new

94e1276

Closes #1617. Part of #626 — Major release plan 17.0.0.

test(skin): remove orphaned Movistar-new screenshot baselines

67c7540

The Movistar-new skin no longer exists after its promotion to the canonical Movistar skin, so its committed image snapshots are obsolete. Regeneration does not delete obsolete image files, so remove them here.

test(skin): keep instability warning on Movistar popover/tooltip tests

6dbab23

These tests were pinned to the legacy Movistar skin because they were unstable on Movistar-new. Since Movistar now is the former Movistar-new, the warning still applies; reword it instead of dropping it.

[bot] Update screenshots

efd8609

test(skin): link Movistar tooltip/popover instability TODOs to tracki…

6426fec

…ng issue Replace the free-text TODO comments with the `// todo <link> <description>` pattern, pointing at the tracking issue for the screenshot instability.

update unstable tests

6dbc6ce

fix unstable tooltip tests

0aa78f1

test(skin): remove orphaned O2-new screenshot snapshots

951aa59

The O2-new skin was removed from all acceptance test parametrizations when O2-new replaced O2. These snapshot images are no longer generated and are removed as obsolete output.

[bot] Update screenshots

2b825ce

Merge branch 'mbertamini/1597-remove-o2new-skin' into mbertamini/1617…

7b900a7

…-remove-movistar-new

Copilot AI review requested due to automatic review settings July 2, 2026 02:17

brtbrt added the AI AI Generated label Jul 2, 2026

brtbrt requested a review from a team July 2, 2026 02:17

Copilot started reviewing on behalf of brtbrt July 2, 2026 02:18 View session

brtbrt changed the title ~~feat(Chore)!: replace data-component-name with data-testid~~ feat(Chore): replace data-component-name with data-testid Jul 2, 2026

brtbrt mentioned this pull request Jul 2, 2026

Replace data-component-name with data-testid in all mistica components #1598

Closed

brtbrt linked an issue Jul 2, 2026 that may be closed by this pull request

Replace data-component-name with data-testid in all mistica components #1598

Closed

Copilot AI reviewed Jul 2, 2026

View reviewed changes

Comment thread src/utils/dom.tsx Outdated

brtbrt requested a review from Marcosld July 14, 2026 12:30

brtbrt added 2 commits July 14, 2026 14:46

fix comments from PR

85e883d

fix comments from PR

be282e0

brtbrt requested a review from a team July 14, 2026 12:51

brtbrt added 3 commits July 14, 2026 14:57

fix comments from PR

f6bf993

fix ts linting problems

32ba436

completely remove componentName

f055051

brtbrt changed the base branch from mbertamini/1617-remove-movistar-new to master July 14, 2026 15:40

brtbrt changed the title ~~feat(Chore): replace data-component-name with data-testid~~ feat(Chore)!: replace data-component-name with data-testid Jul 14, 2026

brtbrt commented Jul 14, 2026

View reviewed changes

Comment thread doc/fonts.md

brtbrt Jul 14, 2026

Copy link
Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was bad by previous PRs. fixed here

brtbrt commented Jul 14, 2026

View reviewed changes

Comment thread packages/generate-design-tokens/index.js

brtbrt Jul 14, 2026

Copy link
Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here: fixed on this PR

brtbrt commented Jul 14, 2026

View reviewed changes

Comment thread src/__type_tests__/data-attributes-type-test.tsx Outdated

trigger CI

2cc2302

fix tests

0b44d73

brtbrt commented Jul 14, 2026

View reviewed changes

atabel approved these changes Jul 15, 2026

View reviewed changes

Comment thread src/__type_tests__/data-attributes-type-test.tsx Outdated

feat(types): allow component-name in DataAttributes

7e85fa6

Remove the `never` restriction on `component-name` in `DataAttributes`, making it a valid key for data attribute objects.

brtbrt enabled auto-merge July 15, 2026 12:32

brtbrt removed the request for review from Marcosld July 15, 2026 12:34

brtbrt disabled auto-merge July 15, 2026 12:35

brtbrt enabled auto-merge July 15, 2026 12:35

brtbrt removed the request for review from a team July 15, 2026 12:35

brtbrt disabled auto-merge July 15, 2026 12:35

brtbrt enabled auto-merge July 15, 2026 12:35

brtbrt merged commit dd9b607 into master Jul 15, 2026
12 checks passed

tuentisre added the released label Jul 15, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(Chore)!: replace data-component-name with data-testid#1622

feat(Chore)!: replace data-component-name with data-testid#1622
brtbrt merged 31 commits into
masterfrom
mbertamini/1598-data-testid

brtbrt commented Jul 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

brtbrt Jul 14, 2026

Uh oh!

brtbrt Jul 14, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 14, 2026 •

edited

Loading

Uh oh!

brtbrt Jul 14, 2026

Uh oh!

Uh oh!

Uh oh!

tuentisre commented Jul 15, 2026

Uh oh!

tuentisre commented Jul 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

brtbrt commented Jul 2, 2026

Changes

Tests

Stack position — 5 of 10

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

brtbrt Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

brtbrt Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brtbrt Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tuentisre commented Jul 15, 2026

Uh oh!

tuentisre commented Jul 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Jul 14, 2026 •

edited

Loading