Skip to content

port to libqofono#7

Draft
simonschmeisser wants to merge 27 commits into
TelepathyIM:stagingfrom
simonschmeisser:qofono
Draft

port to libqofono#7
simonschmeisser wants to merge 27 commits into
TelepathyIM:stagingfrom
simonschmeisser:qofono

Conversation

@simonschmeisser
Copy link
Copy Markdown
Collaborator

@simonschmeisser simonschmeisser commented Aug 2, 2019

this is a port from ofono-qt to qofono which is actively maintained by jolla, implements #2

this includes #5 for now, will rebase once that has been merged

open todos are marked with "todo porting" in the code:

  • compiles without ofono-qt
  • error handling for sendMessage
  • error handling for calls
  • unit tests
  • some more

@simonschmeisser
Copy link
Copy Markdown
Collaborator Author

porting those unit tests feels strange as I need to copy paste a specific version of the qofono lib headers for the mock library @Kaffeine do you think we might be able to use ofono-phonesim for testing instead?

@Kaffeine
Copy link
Copy Markdown
Member

It would be much better to use ofono-phonesim, but I have no idea if it is actually doable.

@simonschmeisser
Copy link
Copy Markdown
Collaborator Author

It seems like I'm having some issues to get account manager to run? the ConnectionTest hangs in TelepathyHelper::instance() and If I make that test fail before that line I get the following warning in output:

tp-qt 0.9.7 WARN: Error parsing config file for connection manager "ofono" - introspecting 

@Kaffeine
Copy link
Copy Markdown
Member

It seems like I'm having some issues to get account manager to run? the ConnectionTest hangs in TelepathyHelper::instance() and If I make that test fail before that line I get the following warning in output:

tp-qt 0.9.7 WARN: Error parsing config file for connection manager "ofono" - introspecting 

Telepathy spec says that connection manager should provide a config file with list of its protocols and capabilities (however clients must have a fallback mechanism that get the needed info by activating the connection manager and calling its methods).
TelepathyQt tests overcome this warning by modifying XDG_DATA_HOME environment variable: https://github.com/TelepathyIM/telepathy-qt/blob/master/tests/CMakeLists.txt#L6

I have some time and I'm going to try this branch right now :).

@Kaffeine
Copy link
Copy Markdown
Member

Kaffeine commented Aug 26, 2019

Meh, telepathy-ofono already has CMake code for that.
If you run the tests via cmake --build . --target test or ctest -VV you'll see that it sets a lot of env vars.

@dilinger
Copy link
Copy Markdown

dilinger commented Feb 2, 2026

It would be much better to use ofono-phonesim, but I have no idea if it is actually doable.

FYI, I ported the tests to phonesim. You can see the code/commits here: https://gitlab.com/ubports/development/core/telepathy-ofono/-/merge_requests/45

If this repo is still active, let me know and I can update and submit a MR here as well. And if not, it might be good to set the repository read-only/archive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants