Remove season ramp constraints and refactor

Signed-off-by: Davey Elder <iandavidelder@gmail.com>

Author: idelder

docs/source/computational_implementation.rst

@@ -268,7 +268,7 @@ which determines the valid indices from other model components. This second meth
 when the indices of a constraint do not exactly align with the indices of the database
 table. For example, the database table :code:`ramp_up_hourly` is indexed by :code:`region`,
 :code:`tech` in the database but one of its inheriting constraints,
-:code:`ramp_up_day_constraint`, is indexed by :code:`region`, :code:`period`,
+:code:`ramp_up_constraint`, is indexed by :code:`region`, :code:`period`,
 :code:`season`, :code:`time_of_day`, :code:`tech`, :code:`vintage` in the model. In this case,
 an index function is needed to determine the valid indices for the constraint.
 
@@ -277,19 +277,19 @@ an index function is needed to determine the valid indices for the constraint.
    .. code-block:: python
       :linenos:
 
-      self.ramp_up_day_constraint_rpsdtv = Set(
-         dimen=6, initialize=operations.ramp_up_day_constraint_indices
+      self.ramp_up_constraint_rpsdtv = Set(
+         dimen=6, initialize=operations.ramp_up_constraint_indices
       )
-      self.ramp_up_day_constraint = Constraint(
-         self.ramp_up_day_constraint_rpsdtv, rule=operations.ramp_up_day_constraint
+      self.ramp_up__constraint = Constraint(
+         self.ramp_up_constraint_rpsdtv, rule=operations.ramp_up_constraint
       )
 
 .. topic:: in ``temoa/components/operations.py`` (return valid indices)
 
    .. code-block:: python
       :linenos:
 
-      def ramp_up_day_constraint_indices(
+      def ramp_up_constraint_indices(
          model: TemoaModel,
       ) -> set[tuple[Region, Period, Season, TimeOfDay, Technology, Vintage]]:
          indices = {
@@ -302,7 +302,7 @@ an index function is needed to determine the valid indices for the constraint.
 
          return indices
 
-With the sparse set (:code:`demand_constraint_rpc` or :code:`ramp_up_day_constraint_rpsdtv`)
+With the sparse set (:code:`demand_constraint_rpc` or :code:`ramp_up_constraint_rpsdtv`)
 created, we can now can use it in place of the sets specified in the non-sparse
 implementation.  Pyomo will now call the constraint implementation rule the
 minimum number of times.

docs/source/mathematical_formulation.rst

@@ -838,9 +838,7 @@ ramp_down_hourly
 
 The :code:`ramp_down_hourly` parameter specifies the fraction of installed capacity
 by which a technology can ramp output down per hour.  This is used in the
-:code:`ramp_down_day_constraint` (between time-of-day slices) and
-:code:`ramp_down_season_constraint` (between the last time-of-day slice in one
-season and the first in the next).
+:code:`ramp_down_constraint`.
 
 
 ramp_up_hourly
@@ -850,8 +848,7 @@ ramp_up_hourly
 
 The :code:`ramp_up_hourly` parameter specifies the fraction of installed capacity
 by which a technology can ramp output up per hour.  This is used in the
-:code:`ramp_up_day_constraint` (between time-of-day slices) and
-:code:`ramp_up_season_constraint` (between seasons).
+:code:`ramp_up_constraint`.
 
 
 reserve_capacity_derate
@@ -1312,13 +1309,9 @@ various physical and operational real-world phenomena.
 
 .. autofunction:: temoa.components.storage.storage_throughput_constraint
 
-.. autofunction:: temoa.components.operations.ramp_up_day_constraint
+.. autofunction:: temoa.components.operations.ramp_up_constraint
 
-.. autofunction:: temoa.components.operations.ramp_down_day_constraint
-
-.. autofunction:: temoa.components.operations.ramp_up_season_constraint
-
-.. autofunction:: temoa.components.operations.ramp_down_season_constraint
+.. autofunction:: temoa.components.operations.ramp_down_constraint
 
 .. autofunction:: temoa.components.reserves.reserve_margin_static