Skip to content

Fix tree mask conflict#62

Merged
liusong1222 merged 2 commits into
Tencent:mainfrom
RuBing-Yang:eagle3
Sep 3, 2025
Merged

Fix tree mask conflict#62
liusong1222 merged 2 commits into
Tencent:mainfrom
RuBing-Yang:eagle3

Conversation

@RuBing-Yang
Copy link
Copy Markdown
Collaborator

Fix problems:

  1. Attention mask shape:
    key/value: target_len = context_len + candidate_token_num
    query: seq_len = bonus_token_num + candidate_token_num
  2. Tree mask already include casual mask
企业微信截图_fdd8bd89-c397-4dca-bbb6-b9367c4df23f

@liusong1222
Copy link
Copy Markdown
Collaborator

LGTM.

@liusong1222 liusong1222 merged commit 91cd578 into Tencent:main Sep 3, 2025
5 checks passed
dawnranger pushed a commit to dawnranger/AngelSlim that referenced this pull request Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants